Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issue 2647763006: Fix race between onFlowIsKnown and native init in FRE code. (Closed)

Created:
3 years, 11 months ago by Alexei Svitkine (slow)
Modified:
3 years, 11 months ago
Reviewers:
Ted C
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix race between onFlowIsKnown and native init in FRE code. As a result of my previous changes to this code, there appeared a race condition where finishNativeInitialization() could be called before onFlowIsKnown() is called. This would either cause sign-in & data reduction pages to simply not be created or could also cause a crash if mFreProperties were restored from a previous run. This CL fixes both of the above issues. If native init happens before onFlowIsKnown, the code will defer creating the extra pages & skipping them to onFlowIsKnown() in the future - which actually matches to how the code was structured originally. BUG=683048 Review-Url: https://codereview.chromium.org/2647763006 Cr-Commit-Position: refs/heads/master@{#445134} Committed: https://chromium.googlesource.com/chromium/src/+/3a70e43d08a3a55b46d62f3e9f8e249e7c8a393b

Patch Set 1 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -4 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunActivity.java View 5 chunks +14 lines, -4 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
Alexei Svitkine (slow)
3 years, 11 months ago (2017-01-20 19:01:24 UTC) #7
Ted C
lgtm
3 years, 11 months ago (2017-01-20 19:28:41 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2647763006/20001
3 years, 11 months ago (2017-01-20 19:30:43 UTC) #11
commit-bot: I haz the power
3 years, 11 months ago (2017-01-20 19:40:58 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/3a70e43d08a3a55b46d62f3e9f8e...

Powered by Google App Engine
This is Rietveld 408576698