Chromium Code Reviews
DescriptionFix race between onFlowIsKnown and native init in FRE code.
As a result of my previous changes to this code, there appeared
a race condition where finishNativeInitialization() could be
called before onFlowIsKnown() is called. This would either cause
sign-in & data reduction pages to simply not be created or
could also cause a crash if mFreProperties were restored from
a previous run.
This CL fixes both of the above issues. If native init happens
before onFlowIsKnown, the code will defer creating the extra
pages & skipping them to onFlowIsKnown() in the future - which
actually matches to how the code was structured originally.
BUG=683048
Review-Url: https://codereview.chromium.org/2647763006
Cr-Commit-Position: refs/heads/master@{#445134}
Committed: https://chromium.googlesource.com/chromium/src/+/3a70e43d08a3a55b46d62f3e9f8e249e7c8a393b
Patch Set 1 : . #
Messages
Total messages: 14 (10 generated)
|
|||||||||||||||||||