Issue 264773017: components: Do not include test code in wifi_component target.

Issue 264773017: components: Do not include test code in wifi_component target. (Closed)

Created:
6 years, 7 months ago by tfarina

Modified:
6 years, 7 months ago

Reviewers:
Lei Zhang, mef

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

components: Do not include test code in wifi_component target. wifi_component target is production code target and thus should not include code that is intended for tests. This changes makes it stop building test code in wifi_component, by extracting and exposing the FakeWiFiService interface in the header file and instantiating it directly where we used to call WiFiService::CreateForTest(). This is the second part of what was discussed in https://codereview.chromium.org/243343002 and started here https://codereview.chromium.org/259543002/ - r266025 BUG=None TEST=build and works as before, no regressions R=mef@chromium.org,thestig@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=268237

Patch Set 1 #

Total comments: 4

Patch Set 2 : mac fixes + lei review #

Patch Set 3 : we only build FakeWiFiService on either win or mac - chromeos is not supported #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+375 lines, -283 lines)			Patch
M	chrome/browser/extensions/api/networking_private/networking_private_apitest.cc	View	1	2 chunks	+2 lines, -3 lines	0 comments	Download
M	chrome/chrome_tests.gypi	View	1 2	1 chunk	+5 lines, -0 lines	0 comments	Download
M	components/wifi.gypi	View		2 chunks	+16 lines, -1 line	0 comments	Download
A	components/wifi/fake_wifi_service.h	View	1	1 chunk	+77 lines, -0 lines	0 comments	Download
M	components/wifi/fake_wifi_service.cc	View		2 chunks	+275 lines, -277 lines	0 comments	Download
M	components/wifi/wifi_service.h	View		1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 9 (0 generated)

Expand Messages | Collapse Messages

Lei Zhang

lgtm https://codereview.chromium.org/264773017/diff/1/components/wifi/fake_wifi_service.h File components/wifi/fake_wifi_service.h (right): https://codereview.chromium.org/264773017/diff/1/components/wifi/fake_wifi_service.h#newcode9 components/wifi/fake_wifi_service.h:9: #include compiler_specific.h for OVERRIDE? https://codereview.chromium.org/264773017/diff/1/components/wifi/fake_wifi_service.h#newcode69 components/wifi/fake_wifi_service.h:69: }; DISALLOW_COPY_AND_ASSIGN ...

6 years, 7 months ago (2014-05-04 00:41:20 UTC) #2

tfarina

https://codereview.chromium.org/264773017/diff/1/components/wifi/fake_wifi_service.h File components/wifi/fake_wifi_service.h (right): https://codereview.chromium.org/264773017/diff/1/components/wifi/fake_wifi_service.h#newcode9 components/wifi/fake_wifi_service.h:9: On 2014/05/04 00:41:20, Lei Zhang wrote: > #include compiler_specific.h ...

6 years, 7 months ago (2014-05-04 03:23:12 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/264773017/40001

6 years, 7 months ago (2014-05-05 18:45:11 UTC) #8

Message was sent while issue was closed.

Change committed as 268237

Expand Messages | Collapse Messages