Remove fake_wifi_service.cc from production wifi component.

Remove fake_wifi_service.cc from production wifi component.

BUG=

[tfarina, 2014-04-18 23:16:07]

You have a link error:

Undefined symbols for architecture i386:
  "wifi::WiFiService::CreateForTest()", referenced from:
      (anonymous
namespace)::ExtensionNetworkingPrivateApiTest::CreateNetworkingPrivateServiceClient(content::BrowserContext*)
in browser_tests.networking_private_apitest.o

I believe you have to add wifi_test_support to browser_tests dependencies list
to fix this error.

Could you also instantiate FakeWifiService directly? Instead of having a
CreateForTest() function in WifiService? I bet you can.

[mef, 2014-04-21 14:05:31]

On 2014/04/18 23:16:07, tfarina wrote:
> You have a link error:
> 
> Undefined symbols for architecture i386:
>   "wifi::WiFiService::CreateForTest()", referenced from:
>       (anonymous
>
namespace)::ExtensionNetworkingPrivateApiTest::CreateNetworkingPrivateServiceClient(content::BrowserContext*)
> in browser_tests.networking_private_apitest.o
> 
> I believe you have to add wifi_test_support to browser_tests dependencies list
> to fix this error.
> 
> Could you also instantiate FakeWifiService directly? Instead of having a
> CreateForTest() function in WifiService? I bet you can.

I could, if I refactor FakeWiFiService to have class definition in a separate .h
file. 
Is it worth it? I dunno, WDYT?

Also, I think dependencies are now correct, but there is one remaining build
error on windows:

FAILED: ninja -t msvc -e environment.x86 -- E:\b\build\goma/gomacc
"E:\b\depot_tools\win_toolchain\vs2013_files\VC\bin\amd64_x86\cl.exe" /nologo
/showIncludes /FC
@obj\components\wifi\wifi_test_support.fake_wifi_service.obj.rsp /c
..\..\components\wifi\fake_wifi_service.cc
/Foobj\components\wifi\wifi_test_support.fake_wifi_service.obj
/Fdobj\components\wifi_test_support.cc.pdb 
e:\b\build\slave\win\build\src\components\wifi\fake_wifi_service.cc(324) :error
C2220: warning treated as error - no 'object' file generated
e:\b\build\slave\win\build\src\components\wifi\fake_wifi_service.cc(324) :
warning C4273: 'wifi::WiFiService::CreateForTest' : inconsistent dll linkage
        e:\b\build\slave\win\build\src\components\wifi\wifi_service.h(45) : see
previous definition of 'CreateForTest'
ninja: build stopped: subcommand failed.

Is it because the wifi_service_test_support target type is a static library?
What should it be?

[tfarina, 2014-04-21 14:59:13]

On 2014/04/21 14:05:31, mef wrote:
> On 2014/04/18 23:16:07, tfarina wrote:
> > You have a link error:
> > 
> > Undefined symbols for architecture i386:
> >   "wifi::WiFiService::CreateForTest()", referenced from:
> >       (anonymous
> >
>
namespace)::ExtensionNetworkingPrivateApiTest::CreateNetworkingPrivateServiceClient(content::BrowserContext*)
> > in browser_tests.networking_private_apitest.o
> > 
> > I believe you have to add wifi_test_support to browser_tests dependencies
list
> > to fix this error.
> > 
> > Could you also instantiate FakeWifiService directly? Instead of having a
> > CreateForTest() function in WifiService? I bet you can.
> 
> I could, if I refactor FakeWiFiService to have class definition in a separate
.h
> file. 
> Is it worth it? I dunno, WDYT?
> 
I think it is worth. If the following fixes the windows error, I think you could
do it as a follow up CL and change wifi_test_support back to a static library.
It is less hacky imo.

https://codereview.chromium.org/243343002/diff/40001/components/wifi.gypi
File components/wifi.gypi (right):

https://codereview.chromium.org/243343002/diff/40001/components/wifi.gypi#new...
components/wifi.gypi:48: 'type': 'static_library',
Yeah, I bet if you change this to <(component) it will fix the remaining error.
This is because CreateForTest is in WifiService which is tagged with
WIFI_EXPORT.

[tfarina, 2014-04-23 22:42:43]

Hi, do you need some help from me? If you are stuck, I think I can cook
something. Just let me know.

[mef, 2014-04-24 00:27:11]

On 2014/04/23 22:42:43, tfarina wrote:
> Hi, do you need some help from me? If you are stuck, I think I can cook
> something. Just let me know.

Yeah, I got disappointed because that change actually made things worse, and
switched to other higher priority tasks.
Considering that wifi component is only implemented for Win and Mac I think it
is wrong that it causes build errors on Android.

FWIW it needs some cleanup, which I've put on my list, but wouldn't
realistically get to for a week or so.

[tfarina, 2014-04-24 03:23:20]

We can start from the android issues.

I put a CL up for review here - https://codereview.chromium.org/259543002

[tfarina, 2014-04-27 21:18:14]

In the next step (2), I will introduce fake_wifi_service.h to host the class
declaration. This should remove the need for CreateForTest().