Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(323)

Issue 264773009: Roll leveldb to r80 / 1.17. (Closed)

Created:
6 years, 7 months ago by cmumford
Modified:
6 years, 7 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Roll leveldb to r80 / 1.17. Changes that affect chrome: - Changed local variable type from int to size_t. This fixes compiler warning to unblock env_chromium_unittests change: https://codereview.chromium.org/213303002 BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=268299

Patch Set 1 #

Patch Set 2 : resync #

Patch Set 3 : resync #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M DEPS View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/leveldatabase/README.chromium View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (0 generated)
cmumford
dgrogan@chromium.org: Please review changes in darin@chromium.org: Please review changes in
6 years, 7 months ago (2014-05-01 23:10:37 UTC) #1
dgrogan
lgtm
6 years, 7 months ago (2014-05-01 23:12:30 UTC) #2
darin (slow to review)
LGTM
6 years, 7 months ago (2014-05-02 07:48:59 UTC) #3
cmumford
The CQ bit was checked by cmumford@chromium.org
6 years, 7 months ago (2014-05-02 15:52:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cmumford@chromium.org/264773009/1
6 years, 7 months ago (2014-05-02 15:53:30 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-02 15:55:51 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium linux_chromium_chromeos_clang_dbg on tryserver.chromium linux_chromium_rel on tryserver.chromium
6 years, 7 months ago (2014-05-02 15:55:51 UTC) #7
cmumford
The CQ bit was checked by cmumford@chromium.org
6 years, 7 months ago (2014-05-02 17:15:57 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cmumford@chromium.org/264773009/20001
6 years, 7 months ago (2014-05-02 17:16:44 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-02 20:58:51 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel on tryserver.chromium
6 years, 7 months ago (2014-05-02 20:58:51 UTC) #11
cmumford
The CQ bit was checked by cmumford@chromium.org
6 years, 7 months ago (2014-05-05 16:13:18 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cmumford@chromium.org/264773009/40001
6 years, 7 months ago (2014-05-05 16:14:12 UTC) #13
commit-bot: I haz the power
6 years, 7 months ago (2014-05-05 23:04:34 UTC) #14
Message was sent while issue was closed.
Change committed as 268299

Powered by Google App Engine
This is Rietveld 408576698