|
|
Created:
6 years, 9 months ago by cmumford Modified:
6 years, 6 months ago CC:
chromium-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@master Visibility:
Public. |
DescriptionAdd env_chromium_unittests to all.gyp.
This existing unit test for Chromium's LevelDB environment was never built.
Building it so that the test can be run on the appropriate bots.
BUG=326304
R=darin@chromium.org
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274947
Patch Set 1 #
Total comments: 1
Patch Set 2 : Also building for Android #Messages
Total messages: 23 (0 generated)
I just confess I wasn't sure exactly which sections to add this to. I put this everywhere that device_unittests was with the exception of aura_builder.
LGTM https://codereview.chromium.org/213303002/diff/1/build/all.gyp File build/all.gyp (right): https://codereview.chromium.org/213303002/diff/1/build/all.gyp#newcode291 build/all.gyp:291: '../third_party/leveldatabase/leveldatabase.gyp:env_chromium_unittests', are you sure you don't want to build this on android?
On 2014/03/26 17:59:00, darin wrote: > LGTM > > https://codereview.chromium.org/213303002/diff/1/build/all.gyp > File build/all.gyp (right): > > https://codereview.chromium.org/213303002/diff/1/build/all.gyp#newcode291 > build/all.gyp:291: > '../third_party/leveldatabase/leveldatabase.gyp:env_chromium_unittests', > are you sure you don't want to build this on android? I had originally left that out because I thought (incorrectly) that Android omitted all third_party test for a reason. I missed WebKit. Uploaded file set 2 to add android.
LGTM
The CQ bit was checked by cmumford@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cmumford@chromium.org/213303002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Retried try job too often on android_clang_dbg for step(s) slave_steps http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_cl...
The CQ bit was checked by cmumford@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cmumford@chromium.org/213303002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Retried try job too often on win_x64_rel for step(s) base_unittests, chrome_elf_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_x64_re...
The CQ bit was checked by cmumford@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cmumford@chromium.org/213303002/20001
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_chromium_gn_compile_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_c...) linux_chromium_gn_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_gn_rel...)
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_gn_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_gn_rel...)
The CQ bit was checked by jsbell@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cmumford@chromium.org/213303002/20001
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_chromium_gn_compile_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_c...) linux_chromium_gn_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_gn_rel...)
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_c...) linux_chromium_gn_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_gn_rel...)
Message was sent while issue was closed.
Committed patchset #2 manually as r274947 (presubmit successful). |