Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 213303002: Add env_chromium_unittests to all.gyp. (Closed)

Created:
6 years, 9 months ago by cmumford
Modified:
6 years, 6 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Add env_chromium_unittests to all.gyp. This existing unit test for Chromium's LevelDB environment was never built. Building it so that the test can be run on the appropriate bots. BUG=326304 R=darin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274947

Patch Set 1 #

Total comments: 1

Patch Set 2 : Also building for Android #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M build/all.gyp View 1 7 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 23 (0 generated)
cmumford
I just confess I wasn't sure exactly which sections to add this to. I put ...
6 years, 9 months ago (2014-03-26 17:33:57 UTC) #1
darin (slow to review)
LGTM https://codereview.chromium.org/213303002/diff/1/build/all.gyp File build/all.gyp (right): https://codereview.chromium.org/213303002/diff/1/build/all.gyp#newcode291 build/all.gyp:291: '../third_party/leveldatabase/leveldatabase.gyp:env_chromium_unittests', are you sure you don't want to ...
6 years, 9 months ago (2014-03-26 17:59:00 UTC) #2
cmumford
On 2014/03/26 17:59:00, darin wrote: > LGTM > > https://codereview.chromium.org/213303002/diff/1/build/all.gyp > File build/all.gyp (right): > ...
6 years, 9 months ago (2014-03-26 18:12:59 UTC) #3
darin (slow to review)
LGTM
6 years, 9 months ago (2014-03-26 18:17:02 UTC) #4
cmumford
The CQ bit was checked by cmumford@chromium.org
6 years, 9 months ago (2014-03-26 18:17:50 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cmumford@chromium.org/213303002/20001
6 years, 9 months ago (2014-03-26 18:21:53 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-26 19:30:58 UTC) #7
commit-bot: I haz the power
Retried try job too often on android_clang_dbg for step(s) slave_steps http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_clang_dbg&number=127053
6 years, 9 months ago (2014-03-26 19:30:58 UTC) #8
cmumford
The CQ bit was checked by cmumford@chromium.org
6 years, 8 months ago (2014-03-31 20:58:46 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cmumford@chromium.org/213303002/20001
6 years, 8 months ago (2014-03-31 20:59:57 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-03-31 22:50:37 UTC) #11
commit-bot: I haz the power
Retried try job too often on win_x64_rel for step(s) base_unittests, chrome_elf_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_x64_rel&number=89950
6 years, 8 months ago (2014-03-31 22:50:37 UTC) #12
cmumford
The CQ bit was checked by cmumford@chromium.org
6 years, 6 months ago (2014-05-30 20:16:51 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cmumford@chromium.org/213303002/20001
6 years, 6 months ago (2014-05-30 20:19:57 UTC) #14
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_chromium_gn_compile_rel on tryserver.chromium ...
6 years, 6 months ago (2014-05-30 23:19:55 UTC) #15
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-05-30 23:34:12 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_gn_rel/builds/12044)
6 years, 6 months ago (2014-05-30 23:34:13 UTC) #17
jsbell
The CQ bit was checked by jsbell@chromium.org
6 years, 6 months ago (2014-06-03 23:40:51 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cmumford@chromium.org/213303002/20001
6 years, 6 months ago (2014-06-03 23:42:10 UTC) #19
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_chromium_gn_compile_rel on tryserver.chromium ...
6 years, 6 months ago (2014-06-03 23:48:01 UTC) #20
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-03 23:52:09 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_compile_rel/builds/10157) linux_chromium_gn_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_gn_rel/builds/12984)
6 years, 6 months ago (2014-06-03 23:52:10 UTC) #22
jsbell
6 years, 6 months ago (2014-06-04 22:58:49 UTC) #23
Message was sent while issue was closed.
Committed patchset #2 manually as r274947 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698