Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 2647703007: Migrate Timer to TaskRunnerTimer in DOMWebSocket. (Closed)

Created:
3 years, 11 months ago by Hwanseung Lee
Modified:
3 years, 11 months ago
Reviewers:
haraken
CC:
chromium-reviews, blink-reviews, haraken, tyoshino+watch_chromium.org, yhirano+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Migrate Timer to TaskRunnerTimer in DOMWebSocket. Migrate Timer to TaskRunnerTimer in DOMWebSocket. The task source for all tasks queued in this section is the WebSocket task source. Spec that defines: https://html.spec.whatwg.org/multipage/comms.html#feedback-from-the-protocol BUG=624694 Review-Url: https://codereview.chromium.org/2647703007 Cr-Commit-Position: refs/heads/master@{#445315} Committed: https://chromium.googlesource.com/chromium/src/+/2f00f12f09c74268db007414c0642e49406c39c2

Patch Set 1 #

Patch Set 2 : Migrate Timer to TaskRunnerTimer in DOMWebSocket. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
M third_party/WebKit/Source/modules/websockets/DOMWebSocket.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/websockets/DOMWebSocket.cpp View 1 3 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 18 (14 generated)
Hwanseung Lee
@haraken PTAL, thank you.
3 years, 11 months ago (2017-01-21 13:11:14 UTC) #9
haraken
Please add a link to the spec to the CL description. https://html.spec.whatwg.org/multipage/comms.html#feedback-from-the-protocol "The task source ...
3 years, 11 months ago (2017-01-23 00:09:13 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2647703007/20001
3 years, 11 months ago (2017-01-23 00:40:27 UTC) #15
commit-bot: I haz the power
3 years, 11 months ago (2017-01-23 02:25:08 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/2f00f12f09c74268db007414c064...

Powered by Google App Engine
This is Rietveld 408576698