Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(360)

Issue 2647703002: Move RTCDataChannel timer to frame-specific TaskRunnerTimer. (Closed)

Created:
3 years, 11 months ago by Byoungkwon Ko
Modified:
3 years, 11 months ago
Reviewers:
haraken
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move RTCDataChannel timer to frame-specific TaskRunnerTimer. Move RTCDataChannel timer m_scheduledEventTimer to frame-specific TaskRunnerTimer. This associates it with the frame's Networking timer task queue. "The task source for the tasks listed in this section is the networking task source."[1] [1] The spec link: https://www.w3.org/TR/webrtc/#operation This CL is migrating tasks/timers from a per-renderer scheduler to a per-frame scheduler: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/80dsbEEOcWY BUG=624694 Review-Url: https://codereview.chromium.org/2647703002 Cr-Commit-Position: refs/heads/master@{#444997} Committed: https://chromium.googlesource.com/chromium/src/+/674ab769d179a6184ead4d616ee6b7e10cf39bf2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M third_party/WebKit/Source/modules/peerconnection/RTCDataChannel.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/peerconnection/RTCDataChannel.cpp View 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 15 (11 generated)
Byoungkwon Ko
PTAL
3 years, 11 months ago (2017-01-19 19:26:21 UTC) #6
haraken
Add a link to the spec to the CL description. https://www.w3.org/TR/webrtc/#operation "The task source for ...
3 years, 11 months ago (2017-01-20 05:07:18 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2647703002/1
3 years, 11 months ago (2017-01-20 06:13:35 UTC) #12
commit-bot: I haz the power
3 years, 11 months ago (2017-01-20 06:19:03 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/674ab769d179a6184ead4d616ee6...

Powered by Google App Engine
This is Rietveld 408576698