Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Unified Diff: chrome/browser/android/preferences/pref_service_bridge.cc

Issue 2647683002: Consolidate Origin- and RegistrableDomain- FilterBuilder into one class (Closed)
Patch Set: Rebase. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/BUILD.gn ('k') | chrome/browser/browsing_data/browsing_data_filter_builder.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/android/preferences/pref_service_bridge.cc
diff --git a/chrome/browser/android/preferences/pref_service_bridge.cc b/chrome/browser/android/preferences/pref_service_bridge.cc
index 5c448a7fe24ba611d000bc45528fc399ff68c31e..7f50a0bdeca2b85fc637aabfd633a25f9fdc0fcd 100644
--- a/chrome/browser/android/preferences/pref_service_bridge.cc
+++ b/chrome/browser/android/preferences/pref_service_bridge.cc
@@ -30,7 +30,6 @@
#include "chrome/browser/browsing_data/browsing_data_helper.h"
#include "chrome/browser/browsing_data/browsing_data_remover.h"
#include "chrome/browser/browsing_data/browsing_data_remover_factory.h"
-#include "chrome/browser/browsing_data/registrable_domain_filter_builder.h"
#include "chrome/browser/content_settings/host_content_settings_map_factory.h"
#include "chrome/browser/engagement/important_sites_util.h"
#include "chrome/browser/history/web_history_service_factory.h"
@@ -644,8 +643,8 @@ static void ClearBrowsingData(
env, jignoring_domains.obj(), &ignoring_domains);
base::android::JavaIntArrayToIntVector(env, jignoring_domain_reasons.obj(),
&ignoring_domain_reasons);
- std::unique_ptr<RegistrableDomainFilterBuilder> filter_builder(
- new RegistrableDomainFilterBuilder(BrowsingDataFilterBuilder::BLACKLIST));
+ std::unique_ptr<BrowsingDataFilterBuilder> filter_builder(
+ BrowsingDataFilterBuilder::Create(BrowsingDataFilterBuilder::BLACKLIST));
for (const std::string& domain : excluding_domains) {
filter_builder->AddRegisterableDomain(domain);
}
« no previous file with comments | « chrome/browser/BUILD.gn ('k') | chrome/browser/browsing_data/browsing_data_filter_builder.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698