Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(578)

Side by Side Diff: chrome/browser/android/preferences/pref_service_bridge.cc

Issue 2647683002: Consolidate Origin- and RegistrableDomain- FilterBuilder into one class (Closed)
Patch Set: Rebase. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/BUILD.gn ('k') | chrome/browser/browsing_data/browsing_data_filter_builder.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/android/preferences/pref_service_bridge.h" 5 #include "chrome/browser/android/preferences/pref_service_bridge.h"
6 6
7 #include <jni.h> 7 #include <jni.h>
8 #include <stddef.h> 8 #include <stddef.h>
9 9
10 #include <memory> 10 #include <memory>
(...skipping 12 matching lines...) Expand all
23 #include "base/metrics/histogram_macros.h" 23 #include "base/metrics/histogram_macros.h"
24 #include "base/scoped_observer.h" 24 #include "base/scoped_observer.h"
25 #include "base/strings/string_split.h" 25 #include "base/strings/string_split.h"
26 #include "base/strings/string_util.h" 26 #include "base/strings/string_util.h"
27 #include "base/values.h" 27 #include "base/values.h"
28 #include "chrome/browser/browser_process.h" 28 #include "chrome/browser/browser_process.h"
29 #include "chrome/browser/browsing_data/browsing_data_filter_builder.h" 29 #include "chrome/browser/browsing_data/browsing_data_filter_builder.h"
30 #include "chrome/browser/browsing_data/browsing_data_helper.h" 30 #include "chrome/browser/browsing_data/browsing_data_helper.h"
31 #include "chrome/browser/browsing_data/browsing_data_remover.h" 31 #include "chrome/browser/browsing_data/browsing_data_remover.h"
32 #include "chrome/browser/browsing_data/browsing_data_remover_factory.h" 32 #include "chrome/browser/browsing_data/browsing_data_remover_factory.h"
33 #include "chrome/browser/browsing_data/registrable_domain_filter_builder.h"
34 #include "chrome/browser/content_settings/host_content_settings_map_factory.h" 33 #include "chrome/browser/content_settings/host_content_settings_map_factory.h"
35 #include "chrome/browser/engagement/important_sites_util.h" 34 #include "chrome/browser/engagement/important_sites_util.h"
36 #include "chrome/browser/history/web_history_service_factory.h" 35 #include "chrome/browser/history/web_history_service_factory.h"
37 #include "chrome/browser/net/prediction_options.h" 36 #include "chrome/browser/net/prediction_options.h"
38 #include "chrome/browser/prefs/incognito_mode_prefs.h" 37 #include "chrome/browser/prefs/incognito_mode_prefs.h"
39 #include "chrome/browser/profiles/profile_manager.h" 38 #include "chrome/browser/profiles/profile_manager.h"
40 #include "chrome/browser/sync/profile_sync_service_factory.h" 39 #include "chrome/browser/sync/profile_sync_service_factory.h"
41 #include "chrome/browser/translate/chrome_translate_client.h" 40 #include "chrome/browser/translate/chrome_translate_client.h"
42 #include "chrome/browser/ui/android/android_about_app_info.h" 41 #include "chrome/browser/ui/android/android_about_app_info.h"
43 #include "chrome/common/channel_info.h" 42 #include "chrome/common/channel_info.h"
(...skipping 593 matching lines...) Expand 10 before | Expand all | Expand 10 after
637 std::vector<std::string> ignoring_domains; 636 std::vector<std::string> ignoring_domains;
638 std::vector<int32_t> ignoring_domain_reasons; 637 std::vector<int32_t> ignoring_domain_reasons;
639 base::android::AppendJavaStringArrayToStringVector( 638 base::android::AppendJavaStringArrayToStringVector(
640 env, jexcluding_domains.obj(), &excluding_domains); 639 env, jexcluding_domains.obj(), &excluding_domains);
641 base::android::JavaIntArrayToIntVector(env, jexcluding_domain_reasons.obj(), 640 base::android::JavaIntArrayToIntVector(env, jexcluding_domain_reasons.obj(),
642 &excluding_domain_reasons); 641 &excluding_domain_reasons);
643 base::android::AppendJavaStringArrayToStringVector( 642 base::android::AppendJavaStringArrayToStringVector(
644 env, jignoring_domains.obj(), &ignoring_domains); 643 env, jignoring_domains.obj(), &ignoring_domains);
645 base::android::JavaIntArrayToIntVector(env, jignoring_domain_reasons.obj(), 644 base::android::JavaIntArrayToIntVector(env, jignoring_domain_reasons.obj(),
646 &ignoring_domain_reasons); 645 &ignoring_domain_reasons);
647 std::unique_ptr<RegistrableDomainFilterBuilder> filter_builder( 646 std::unique_ptr<BrowsingDataFilterBuilder> filter_builder(
648 new RegistrableDomainFilterBuilder(BrowsingDataFilterBuilder::BLACKLIST)); 647 BrowsingDataFilterBuilder::Create(BrowsingDataFilterBuilder::BLACKLIST));
649 for (const std::string& domain : excluding_domains) { 648 for (const std::string& domain : excluding_domains) {
650 filter_builder->AddRegisterableDomain(domain); 649 filter_builder->AddRegisterableDomain(domain);
651 } 650 }
652 651
653 if (!excluding_domains.empty() || !ignoring_domains.empty()) { 652 if (!excluding_domains.empty() || !ignoring_domains.empty()) {
654 ImportantSitesUtil::RecordBlacklistedAndIgnoredImportantSites( 653 ImportantSitesUtil::RecordBlacklistedAndIgnoredImportantSites(
655 GetOriginalProfile(), excluding_domains, excluding_domain_reasons, 654 GetOriginalProfile(), excluding_domains, excluding_domain_reasons,
656 ignoring_domains, ignoring_domain_reasons); 655 ignoring_domains, ignoring_domain_reasons);
657 } 656 }
658 657
(...skipping 558 matching lines...) Expand 10 before | Expand all | Expand 10 after
1217 1216
1218 return ConvertJavaStringToUTF8(android_permission); 1217 return ConvertJavaStringToUTF8(android_permission);
1219 } 1218 }
1220 1219
1221 static void SetSupervisedUserId(JNIEnv* env, 1220 static void SetSupervisedUserId(JNIEnv* env,
1222 const JavaParamRef<jobject>& obj, 1221 const JavaParamRef<jobject>& obj,
1223 const JavaParamRef<jstring>& pref) { 1222 const JavaParamRef<jstring>& pref) {
1224 GetPrefService()->SetString(prefs::kSupervisedUserId, 1223 GetPrefService()->SetString(prefs::kSupervisedUserId,
1225 ConvertJavaStringToUTF8(env, pref)); 1224 ConvertJavaStringToUTF8(env, pref));
1226 } 1225 }
OLDNEW
« no previous file with comments | « chrome/browser/BUILD.gn ('k') | chrome/browser/browsing_data/browsing_data_filter_builder.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698