Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Unified Diff: third_party/WebKit/LayoutTests/fast/dom/named-constructor-prototype-chain.html

Issue 2647643002: Fix V8 bindings for named constructors to set prototype object correctly (Closed)
Patch Set: Review feedback Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/fast/dom/named-constructor-prototype-chain.html
diff --git a/third_party/WebKit/LayoutTests/fast/dom/named-constructor-prototype-chain.html b/third_party/WebKit/LayoutTests/fast/dom/named-constructor-prototype-chain.html
new file mode 100644
index 0000000000000000000000000000000000000000..e0cbcd34dd6517b4e2be76d9ac90e57018b675f1
--- /dev/null
+++ b/third_party/WebKit/LayoutTests/fast/dom/named-constructor-prototype-chain.html
@@ -0,0 +1,14 @@
+
+<!DOCTYPE html>
+<script src="../../resources/testharness.js"></script>
+<script src="../../resources/testharnessreport.js"></script>
+<script>
+test(function(t)
+{
+ //assert_equals(Image.name, "Image", "Image name should be Image (not HTMLImageElement)");
Yuki 2017/02/21 06:57:36 We want this test. https://heycam.github.io/webid
+ //assert_equals(Image.__proto__, HTMLElement, "Image __proto__ is HTMLElement");
sashab 2017/02/21 06:37:29 Just to confirm -- we don't want these, correct?
Yuki 2017/02/21 06:57:36 https://heycam.github.io/webidl/#named-constructor
+ assert_equals(Image.prototype, HTMLImageElement.prototype, "Image.prototype is same as HTMLImageElement.prototype");
+ assert_equals(new Image().__proto__, HTMLImageElement.prototype, "Image __proto__ is HTMLImageElement prototype ");
+ assert_equals(Image.prototype.__proto__, HTMLElement.prototype, "Image.prototype __proto__ is HTMLElement prototype");
+}, "NamedConstructor creates the correct object structure.");
+</script>

Powered by Google App Engine
This is Rietveld 408576698