third_party/WebKit/LayoutTests/fast/dom/named-constructor-prototype-chain.html - Issue 2647643002: Fix V8 bindings for named constructors to set prototype object correctly

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/dom/named-constructor-prototype-chain.html

Issue 2647643002: Fix V8 bindings for named constructors to set prototype object correctly (Closed)

Patch Set: Review feedback Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1

	2 <!DOCTYPE html>

	3 <script src="../../resources/testharness.js"></script>

	4 <script src="../../resources/testharnessreport.js"></script>

	5 <script>

	6 test(function(t)

	7 {

	8 //assert_equals(Image.name, "Image", "Image name should be Image (not HTMLIm ageElement)");
	Yuki 2017/02/21 06:57:36 We want this test. https://heycam.github.io/webid We want this test. https://heycam.github.io/webidl/#named-constructors step 3. Perform ! SetFunctionName(F, id). This means that Image.name should be "Image".
	9 //assert_equals(Image.__proto__, HTMLElement, "Image __proto__ is HTMLElemen t");
	sashab 2017/02/21 06:37:29 Just to confirm -- we don't want these, correct? Just to confirm -- we don't want these, correct? Yuki 2017/02/21 06:57:36 https://heycam.github.io/webidl/#named-constructor Show quoted text On 2017/02/21 06:37:29, sashab wrote: > Just to confirm -- we don't want these, correct? https://heycam.github.io/webidl/#named-constructors step 2. Let F be ! CreateBuiltinFunction(realm, steps, %FunctionPrototype% of realm). This means that Image.__proto__ should be Function.prototype (not HTMLElement).
	10 assert_equals(Image.prototype, HTMLImageElement.prototype, "Image.prototype is same as HTMLImageElement.prototype");

	11 assert_equals(new Image().__proto__, HTMLImageElement.prototype, "Image __pr oto__ is HTMLImageElement prototype ");

	12 assert_equals(Image.prototype.__proto__, HTMLElement.prototype, "Image.proto type __proto__ is HTMLElement prototype");

	13 }, "NamedConstructor creates the correct object structure.");

	14 </script>

OLD	NEW