Make KURL::protocolIs take StringView (+ DCHECK cleanups)

Make KURL::protocolIs take StringView (+ DCHECK cleanups)

This ensures callers who use literal strings get strlen() optimized away.

BUG=615174
Review-Url: https://codereview.chromium.org/2647633006
Cr-Commit-Position: refs/heads/master@{#445132}
Committed: https://chromium.googlesource.com/chromium/src/+/7e153cec8a4925c2d913031c3104b785b18658c5

[Charlie Harrison, 2017-01-20 02:31:17]

The CQ bit was checked by csharrison@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-20 02:31:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-20 02:34:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-20 02:34:37]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[Charlie Harrison, 2017-01-20 02:47:50]

The CQ bit was checked by csharrison@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-20 02:48:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-20 03:12:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-20 03:12:31]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Charlie Harrison, 2017-01-20 15:41:04]

The CQ bit was checked by csharrison@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-20 15:41:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Charlie Harrison, 2017-01-20 15:45:38]

Description was changed from

==========
Make KURL::protocolIs take StringView (+ DCHECK cleanups)

BUG=615174
==========

to

==========
Make KURL::protocolIs take StringView (+ DCHECK cleanups)

This ensures callers who use literal strings get strlen() optimized away.

BUG=615174
==========

[Charlie Harrison, 2017-01-20 15:45:57]

The CQ bit was checked by csharrison@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-20 15:46:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Charlie Harrison, 2017-01-20 15:46:48]

The CQ bit was checked by csharrison@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-20 15:46:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Charlie Harrison, 2017-01-20 15:51:33]

csharrison@chromium.org changed reviewers:
+ esprehn@chromium.org

[Charlie Harrison, 2017-01-20 15:51:34]

esprehn: PTAL (simple review)

[esprehn, 2017-01-20 17:50:04]

lgtm

https://codereview.chromium.org/2647633006/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/weborigin/KURL.cpp (right):

https://codereview.chromium.org/2647633006/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/weborigin/KURL.cpp:55: DCHECK(c > ' ' && c <
0x7F && !(c >= 'A' && c <= 'Z'));
This could probably be simpler I think? You want isalnum and dashes?

No need to fix in this patch though.

[Charlie Harrison, 2017-01-20 17:53:13]

The CQ bit was checked by csharrison@chromium.org

[commit-bot: I haz the power, 2017-01-20 17:53:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-20 17:54:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-20 17:54:24]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[Charlie Harrison, 2017-01-20 18:01:27]

The CQ bit was checked by csharrison@chromium.org

[commit-bot: I haz the power, 2017-01-20 18:01:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-20 19:36:48]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1484935287794360,
"parent_rev": "95d35ca10ca853e71051e645596d8d4b19774cbc", "commit_rev":
"7e153cec8a4925c2d913031c3104b785b18658c5"}

[commit-bot: I haz the power, 2017-01-20 19:37:19]

Description was changed from

==========
Make KURL::protocolIs take StringView (+ DCHECK cleanups)

This ensures callers who use literal strings get strlen() optimized away.

BUG=615174
==========

to

==========
Make KURL::protocolIs take StringView (+ DCHECK cleanups)

This ensures callers who use literal strings get strlen() optimized away.

BUG=615174

Review-Url: https://codereview.chromium.org/2647633006
Cr-Commit-Position: refs/heads/master@{#445132}
Committed:
https://chromium.googlesource.com/chromium/src/+/7e153cec8a4925c2d913031c3104...
==========

[commit-bot: I haz the power, 2017-01-20 19:37:23]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/7e153cec8a4925c2d913031c3104...