Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Issue 2647633004: [Blink] Don't center images in Android WebViews (Closed)

Created:
3 years, 11 months ago by gone
Modified:
3 years, 11 months ago
CC:
chromium-reviews, blink-reviews, dglazkov+blink, blink-reviews-html_chromium.org
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

[Blink] Don't center images in Android WebViews Android WebViews currently get into a loop where Blink's ImageDocument::windowSizeChanged() is called, causing WebViews to be resized larger, causing Blink's windowSizeChanged() to be called. Instead of using a different height for the calculation, it was decided on the bug that Android WebViews shouldn't return true for shouldShrinkToFit(), treating them similarly to non-main frames. BUG=679709 TBR=aelias,pdr Original-Review-Url: https://codereview.chromium.org/2646663002 Original-Cr-Commit-Position: refs/heads/master@{#444842} Review-Url: https://codereview.chromium.org/2647633004 . Cr-Commit-Position: refs/branch-heads/2924@{#805} Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059} Committed: https://chromium.googlesource.com/chromium/src/+/d7252652724ed7adf1c560348596d826d34f1fe2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -2 lines) Patch
M third_party/WebKit/Source/core/html/ImageDocument.h View 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/ImageDocument.cpp View 2 chunks +7 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/ImageDocumentTest.cpp View 2 chunks +23 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
gone
3 years, 11 months ago (2017-01-19 21:46:02 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d7252652724ed7adf1c560348596d826d34f1fe2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698