Do not size PermissionSelectorRow to preferred size

Do not size PermissionSelectorRow to preferred size

PermissionSelectorRow's preferred size is smaller than the width of the Page
Info Bubble, so when a permission changes, resizing to the preferred size means
that the row shrinks smaller than the other rows and the dropdown jumps around.

Instead, simply call Layout() to do a fresh layout of the row.

The parent()->SizeToPreferredSize() call is no longer necessary because
WebsiteSettingsPopupView calls SizeToContents() when a permission is
changed. Note that bug 655880 may want to reintroduce the
PermissionSelectorRow::ChildPreferredSizeChanged override and propagate the
change to WebsiteSettingsPopupView that way instead of via OnPermissionChanged,
but it's not needed now -- and I'm guessing that, for that bug,
PermissionSelectorRow::ChildPreferredSizeChanged may want to call
parent()->PreferredSizeChanged(), rather than calling SizeToPreferredSize()
(which assumes that the parent ought to be at its preferred size).

BUG=657286
TEST=On Windows/Linux, visit https://google.com (or any other site) and open
Page Info by clicking on the security indicator in the omnibox. Change a
permission, change it again. Observe that the dropdown does not jump to the left
of where it started.

Review-Url: https://codereview.chromium.org/2647633002
Cr-Commit-Position: refs/heads/master@{#445017}
Committed: https://chromium.googlesource.com/chromium/src/+/f24aa8ad5db849c114c91cddcc297475b8ead2c8

[estark, 2017-01-19 06:43:40]

The CQ bit was checked by estark@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-19 06:43:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[estark, 2017-01-19 06:46:01]

estark@chromium.org changed reviewers:
+ lgarron@chromium.org

[estark, 2017-01-19 06:46:02]

lgarron: have only tested on Linux so far (not Mac), but lmk if you think this
makes any sense at all

[commit-bot: I haz the power, 2017-01-19 08:14:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-19 08:14:23]

Dry run: This issue passed the CQ dry run.

[lgarron, 2017-01-19 22:02:19]

lgarron@chromium.org changed reviewers:
+ msw@chromium.org

[lgarron, 2017-01-19 22:02:20]

LGTM, since it works on Mac and I don't think there are any horrible performance
implications.

Adding msw@, who has done the previous reviews for this code.

[msw, 2017-01-20 07:34:16]

nice! lgtm

[estark, 2017-01-20 07:45:05]

The CQ bit was checked by estark@chromium.org

[commit-bot: I haz the power, 2017-01-20 07:45:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-20 08:45:45]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1484898305882500, "parent_rev":
"18491e4f87ce2e5e53f64dad2a3da0a1f5688e01", "commit_rev":
"f24aa8ad5db849c114c91cddcc297475b8ead2c8"}

[commit-bot: I haz the power, 2017-01-20 08:46:21]

Description was changed from

==========
Do not size PermissionSelectorRow to preferred size

PermissionSelectorRow's preferred size is smaller than the width of the Page
Info Bubble, so when a permission changes, resizing to the preferred size means
that the row shrinks smaller than the other rows and the dropdown jumps around.

Instead, simply call Layout() to do a fresh layout of the row.

The parent()->SizeToPreferredSize() call is no longer necessary because
WebsiteSettingsPopupView calls SizeToContents() when a permission is
changed. Note that bug 655880 may want to reintroduce the
PermissionSelectorRow::ChildPreferredSizeChanged override and propagate the
change to WebsiteSettingsPopupView that way instead of via OnPermissionChanged,
but it's not needed now -- and I'm guessing that, for that bug,
PermissionSelectorRow::ChildPreferredSizeChanged may want to call
parent()->PreferredSizeChanged(), rather than calling SizeToPreferredSize()
(which assumes that the parent ought to be at its preferred size).

BUG=657286
TEST=On Windows/Linux, visit https://google.com (or any other site) and open
Page Info by clicking on the security indicator in the omnibox. Change a
permission, change it again. Observe that the dropdown does not jump to the left
of where it started.
==========

to

==========
Do not size PermissionSelectorRow to preferred size

PermissionSelectorRow's preferred size is smaller than the width of the Page
Info Bubble, so when a permission changes, resizing to the preferred size means
that the row shrinks smaller than the other rows and the dropdown jumps around.

Instead, simply call Layout() to do a fresh layout of the row.

The parent()->SizeToPreferredSize() call is no longer necessary because
WebsiteSettingsPopupView calls SizeToContents() when a permission is
changed. Note that bug 655880 may want to reintroduce the
PermissionSelectorRow::ChildPreferredSizeChanged override and propagate the
change to WebsiteSettingsPopupView that way instead of via OnPermissionChanged,
but it's not needed now -- and I'm guessing that, for that bug,
PermissionSelectorRow::ChildPreferredSizeChanged may want to call
parent()->PreferredSizeChanged(), rather than calling SizeToPreferredSize()
(which assumes that the parent ought to be at its preferred size).

BUG=657286
TEST=On Windows/Linux, visit https://google.com (or any other site) and open
Page Info by clicking on the security indicator in the omnibox. Change a
permission, change it again. Observe that the dropdown does not jump to the left
of where it started.

Review-Url: https://codereview.chromium.org/2647633002
Cr-Commit-Position: refs/heads/master@{#445017}
Committed:
https://chromium.googlesource.com/chromium/src/+/f24aa8ad5db849c114c91cddcc29...
==========

[commit-bot: I haz the power, 2017-01-20 08:46:23]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f24aa8ad5db849c114c91cddcc29...