Use entities in code_emitter_task

Use entities in code_emitter_task

R=sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/240797ca12fe48f91039af7f0345573d56932a81

[Johnni Winther, 2017-01-19 15:54:03]

johnniwinther@google.com changed reviewers:
+ sigmund@google.com

[Siggi Cherem (dart-lang), 2017-01-19 16:54:26]

lgtm

https://codereview.chromium.org/2647613004/diff/1/pkg/compiler/lib/src/ssa/bu...
File pkg/compiler/lib/src/ssa/builder_kernel.dart (right):

https://codereview.chromium.org/2647613004/diff/1/pkg/compiler/lib/src/ssa/bu...
pkg/compiler/lib/src/ssa/builder_kernel.dart:2032: new
StaticUse.foreignUse(astAdapter.getMember(staticTarget)));
shouldn't this change too? maybe pull it out into a temporary variable?

unrelated, but related - this reminds me that foreignUse is marked as
deprecated, could you add a comment in use.dart indicating what we are supposed
to do instead?

[Johnni Winther, 2017-01-20 08:37:02]

https://codereview.chromium.org/2647613004/diff/1/pkg/compiler/lib/src/ssa/bu...
File pkg/compiler/lib/src/ssa/builder_kernel.dart (right):

https://codereview.chromium.org/2647613004/diff/1/pkg/compiler/lib/src/ssa/bu...
pkg/compiler/lib/src/ssa/builder_kernel.dart:2032: new
StaticUse.foreignUse(astAdapter.getMember(staticTarget)));
On 2017/01/19 16:54:25, Siggi Cherem (dart-lang) wrote:
> shouldn't this change too? maybe pull it out into a temporary variable?
> 
> unrelated, but related - this reminds me that foreignUse is marked as
> deprecated, could you add a comment in use.dart indicating what we are
supposed
> to do instead?

Done. Done.

[Johnni Winther, 2017-01-20 08:59:29]

Description was changed from

==========
Use entities in code_emitter_task
==========

to

==========
Use entities in code_emitter_task

R=sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/240797ca12fe48f91039af7f0345573d56932a81
==========

[Johnni Winther, 2017-01-20 08:59:30]

Committed patchset #2 (id:20001) manually as
240797ca12fe48f91039af7f0345573d56932a81 (presubmit successful).