Use entities in code_emitter_task

pkg/compiler/lib/src/ssa/builder_kernel.dart

 // Copyright (c) 2016, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 import 'package:kernel/ast.dart' as ir;
 
 import '../closure.dart';
 import '../common.dart';
 import '../common/codegen.dart' show CodegenRegistry, CodegenWorkItem;
 import '../common/names.dart';
@@ skipping 2011 matching lines @@
     if (closure is ir.StaticGet) {
       ir.Member staticTarget = closure.target;
       if (staticTarget is ir.Procedure) {
         if (staticTarget.kind == ir.ProcedureKind.Method) {
           ir.FunctionNode function = staticTarget.function;
           if (function != null &&
               function.requiredParameterCount ==
                   function.positionalParameters.length &&
               function.namedParameters.isEmpty) {
             registry?.registerStaticUse(
                 new StaticUse.foreignUse(astAdapter.getMember(staticTarget)));

[Siggi Cherem (dart-lang), 2017/01/19 16:54:25]

shouldn't this change too? maybe pull it out into a temporary variable?

unrelated, but related - this reminds me that foreignUse is marked as
deprecated, could you add a comment in use.dart indicating what we are supposed
to do instead?

[Johnni Winther, 2017/01/20 08:37:02]

Done. Done.

             push(new HForeignCode(
                 js.js.expressionTemplateYielding(backend.emitter
-                    .staticFunctionAccess(astAdapter.getMember(staticTarget))),
+                    .staticFunctionAccess(astAdapter.getMethod(staticTarget))),
                 commonMasks.dynamicType,
                 <HInstruction>[],
                 nativeBehavior: native.NativeBehavior.PURE));
             return;
           }
           problem = 'does not handle a closure with optional parameters';
         }
       }
     }
 
@@ skipping 833 matching lines @@
     enterBlock.setBlockFlow(
         new HTryBlockInformation(
             kernelBuilder.wrapStatementGraph(bodyGraph),
             exception,
             kernelBuilder.wrapStatementGraph(catchGraph),
             kernelBuilder.wrapStatementGraph(finallyGraph)),
         exitBlock);
     kernelBuilder.inTryStatement = previouslyInTryStatement;
   }
 }