Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(416)

Issue 2647593002: [Android] Add an option in CCT to disable star and download button (Closed)

Created:
3 years, 11 months ago by Ian Wen
Modified:
3 years, 11 months ago
Reviewers:
Yusuf
CC:
chromium-reviews, lizeb+watch-custom-tabs_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Add an option in CCT to disable star and download button After this CL, some CCT clients can choose to disable some newly added buttons in menu. BUG=682453 Review-Url: https://codereview.chromium.org/2647593002 Cr-Commit-Position: refs/heads/master@{#444833} Committed: https://chromium.googlesource.com/chromium/src/+/34cf6ef588ab528d111fab5efd93e481c5a12d6c

Patch Set 1 #

Patch Set 2 : nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -3 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabAppMenuPropertiesDelegate.java View 3 chunks +7 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabIntentDataProvider.java View 1 4 chunks +27 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Ian Wen
3 years, 11 months ago (2017-01-18 23:32:07 UTC) #2
Yusuf
lgtm
3 years, 11 months ago (2017-01-19 19:35:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2647593002/20001
3 years, 11 months ago (2017-01-19 19:42:02 UTC) #5
commit-bot: I haz the power
3 years, 11 months ago (2017-01-19 20:21:59 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/34cf6ef588ab528d111fab5efd93...

Powered by Google App Engine
This is Rietveld 408576698