Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(508)

Issue 2647573002: WebUI: Animate connecting network svg icons (Closed)

Created:
3 years, 11 months ago by stevenjb
Modified:
3 years, 11 months ago
CC:
chromium-reviews, michaelpg+watch-elements_chromium.org, stevenjb+watch-md-settings_chromium.org, dbeam+watch-elements_chromium.org, oshima+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

WebUI: Animate connecting network svg icons This affects existing Settings, MD Settings, and MD OOBE. Note: writing tests for this is tracked in crbug.com/679561 and is currently blocked on loading of extension APIs for tests (connemt #1). BUG=653425 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -30 lines) Patch
M ui/webui/resources/cr_elements/network/cr_network_icon.html View 1 chunk +2 lines, -1 line 0 comments Download
M ui/webui/resources/cr_elements/network/cr_network_icon.js View 1 3 chunks +75 lines, -29 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
stevenjb
3 years, 11 months ago (2017-01-19 18:39:19 UTC) #5
Alexander Alekseev
lgtm
3 years, 11 months ago (2017-01-19 19:27:54 UTC) #6
Dan Beam
let's use the css keyframe version instead
3 years, 11 months ago (2017-01-21 01:07:11 UTC) #7
stevenjb
3 years, 11 months ago (2017-01-21 19:06:46 UTC) #8
On 2017/01/21 01:07:11, Dan Beam (slow - converging) wrote:
> let's use the css keyframe version instead

Closing in favor of https://codereview.chromium.org/2648843002/

Powered by Google App Engine
This is Rietveld 408576698