Chromium Code Reviews Chromium Code Reviews
Issue 2647533002:
Force compositing inputs to be clean for getBoundingClientRect (Closed)
| Index: third_party/WebKit/LayoutTests/fast/css/sticky/sticky-position-valid-after-layout.html |
| diff --git a/third_party/WebKit/LayoutTests/fast/css/sticky/sticky-position-valid-after-layout.html b/third_party/WebKit/LayoutTests/fast/css/sticky/sticky-position-valid-after-layout.html |
| new file mode 100644 |
| index 0000000000000000000000000000000000000000..b039a1c4dfdc3308be2bc76732cd1bb6c65d09d6 |
| --- /dev/null |
| +++ b/third_party/WebKit/LayoutTests/fast/css/sticky/sticky-position-valid-after-layout.html |
| @@ -0,0 +1,66 @@ |
| +<!DOCTYPE html> |
| +<script src="../../../resources/testharness.js"></script> |
| +<script src="../../../resources/testharnessreport.js"></script> |
| +<style> |
| +body { |
| + margin: 0; |
| +} |
| + |
| +#scroller { |
| + height: 100px; |
| + width: 200px; |
| + overflow: scroll; |
| +} |
| + |
| +.padding { |
| + width: 400px; |
| + height: 500px; |
| +} |
| + |
| +#sticky { |
| + width: 25px; |
| + height: 25px; |
| + position: sticky; |
| + top: 20px; |
| + left: 50px; |
| +} |
| +</style> |
| + |
| +<div id="scroller"> |
| + <div id="sticky"></div> |
| + <div class="padding"></div> |
| +</div> |
| + |
| +<script> |
| +if (window.internals) { |
| + internals.settings.setCSSStickyPositionEnabled(true); |
| +} |
| + |
| +test(function() { |
| + var scroller = document.getElementById('scroller'); |
| + var sticky = document.getElementById('sticky'); |
| + scroller.scrollTop = 100; |
| + scroller.scrollLeft = 50; |
| + scroller.append(document.createElement('div')); |
| + assert_equals(sticky.getBoundingClientRect().top, 20); |
| + assert_equals(sticky.getBoundingClientRect().left, 50); |
| +}, "getBoundingClientRect should be correct for sticky after script-caused layout"); |
| + |
| +test(function() { |
| + var scroller = document.getElementById('scroller'); |
| + var sticky = document.getElementById('sticky'); |
| + scroller.scrollTop = 100; |
| + scroller.scrollLeft = 50; |
| + scroller.append(document.createElement('div')); |
|
flackr
2017/01/23 16:43:50
Can we have a test which inserts the sticky elemen
smcgruer
2017/01/24 15:26:30
Fantastic idea. This actually helped expose that m
|
| + assert_equals(sticky.offsetTop, 120); |
| +}, "offsetTop should be correct for sticky after script-caused layout"); |
| + |
| +test(function() { |
| + var scroller = document.getElementById('scroller'); |
| + var sticky = document.getElementById('sticky'); |
| + scroller.scrollTop = 100; |
| + scroller.scrollLeft = 50; |
| + scroller.append(document.createElement('div')); |
| + assert_equals(sticky.offsetLeft, 100); |
| +}, "offsetLeft should be correct for sticky after script-caused layout"); |
|
flackr
2017/01/23 16:43:50
offsetTop and offsetLeft could probably be a singl
smcgruer
2017/01/24 15:26:30
Done.
|
| +</script> |
