third_party/WebKit/LayoutTests/fast/css/sticky/sticky-position-valid-after-layout.html - Issue 2647533002: Force compositing inputs to be clean for getBoundingClientRect

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/css/sticky/sticky-position-valid-after-layout.html

Issue 2647533002: Force compositing inputs to be clean for getBoundingClientRect (Closed)

Patch Set: Add LayoutTests to validate post-layout behavior Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/fast/css/sticky/sticky-position-works-with-scroll-apis.html » ('j') | third_party/WebKit/Source/core/dom/Element.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script src="../../../resources/testharness.js"></script>

	3 <script src="../../../resources/testharnessreport.js"></script>

	4 <style>

	5 body {

	6 margin: 0;

	7 }

	8

	9 #scroller {

	10 height: 100px;

	11 width: 200px;

	12 overflow: scroll;

	13 }

	14

	15 .padding {

	16 width: 400px;

	17 height: 500px;

	18 }

	19

	20 #sticky {

	21 width: 25px;

	22 height: 25px;

	23 position: sticky;

	24 top: 20px;

	25 left: 50px;

	26 }

	27 </style>

	28

	29 <div id="scroller">

	30 <div id="sticky"></div>

	31 <div class="padding"></div>

	32 </div>

	33

	34 <script>

	35 if (window.internals) {

	36 internals.settings.setCSSStickyPositionEnabled(true);

	37 }

	38

	39 test(function() {

	40 var scroller = document.getElementById('scroller');

	41 var sticky = document.getElementById('sticky');

	42 scroller.scrollTop = 100;

	43 scroller.scrollLeft = 50;

	44 scroller.append(document.createElement('div'));

	45 assert_equals(sticky.getBoundingClientRect().top, 20);

	46 assert_equals(sticky.getBoundingClientRect().left, 50);

	47 }, "getBoundingClientRect should be correct for sticky after script-caused layou t");

	48

	49 test(function() {

	50 var scroller = document.getElementById('scroller');

	51 var sticky = document.getElementById('sticky');

	52 scroller.scrollTop = 100;

	53 scroller.scrollLeft = 50;

	54 scroller.append(document.createElement('div'));
	flackr 2017/01/23 16:43:50 Can we have a test which inserts the sticky elemen Can we have a test which inserts the sticky element and immediately queries it? smcgruer 2017/01/24 15:26:30 Fantastic idea. This actually helped expose that m Show quoted text On 2017/01/23 16:43:50, flackr wrote: > Can we have a test which inserts the sticky element and immediately queries it? Fantastic idea. This actually helped expose that my fix for offsetTop/offsetLeft was wrong; the actual JS bindings end up calling HTMLElement::offsetTopForBinding, which has almost exactly the same implementation but isn't an override... I intend to pursue making that situation go away, but in the meantime I added the same refresh code to HTMLElement::offsetTopForBinding. Oh, and added an insert test.
	55 assert_equals(sticky.offsetTop, 120);

	56 }, "offsetTop should be correct for sticky after script-caused layout");

	57

	58 test(function() {

	59 var scroller = document.getElementById('scroller');

	60 var sticky = document.getElementById('sticky');

	61 scroller.scrollTop = 100;

	62 scroller.scrollLeft = 50;

	63 scroller.append(document.createElement('div'));

	64 assert_equals(sticky.offsetLeft, 100);

	65 }, "offsetLeft should be correct for sticky after script-caused layout");
	flackr 2017/01/23 16:43:50 offsetTop and offsetLeft could probably be a singl offsetTop and offsetLeft could probably be a single test. smcgruer 2017/01/24 15:26:30 Done. Show quoted text On 2017/01/23 16:43:50, flackr wrote: > offsetTop and offsetLeft could probably be a single test. Done.
	66 </script>

OLD	NEW