Force compositing inputs to be clean for getBoundingClientRect

third_party/WebKit/Source/core/dom/Element.cpp

Index: third_party/WebKit/Source/core/dom/Element.cpp
diff --git a/third_party/WebKit/Source/core/dom/Element.cpp b/third_party/WebKit/Source/core/dom/Element.cpp
index d5ea539ee3527b4a3f90bb8e3b32abb76b499bdf..9372ccbaad52318f96d6660172732539e012025e 100644
--- a/third_party/WebKit/Source/core/dom/Element.cpp
+++ b/third_party/WebKit/Source/core/dom/Element.cpp
@@ -1120,6 +1120,9 @@ IntRect Element::visibleBoundsInVisualViewport() const {
 
 void Element::clientQuads(Vector<FloatQuad>& quads) {
   document().updateStyleAndLayoutIgnorePendingStylesheetsForNode(this);
+  FrameView* view = document().view();

[flackr, 2017/01/18 21:11:10]

nit: We tend to use the following style to scope conditionally used optional
variables
if (FrameView* view = document().view())
  ... code which uses view

[smcgruer, 2017/01/18 21:17:13]

Done.

+  if (view)
+    view->updateLifecycleToCompositingCleanPlusScrolling();

[flackr, 2017/01/18 21:11:10]

Was this call necessary? Does updateAllLifecyclePhasesExceptPaint not get the
lifecycle past compositing inputs?

[smcgruer, 2017/01/18 21:17:13]

I was aiming for minimal lifecycle update. updateAllLifecyclePhasesExceptPaint()
should work the same, except it will also do the following after
CompositingClean:

    InPaintInvalidation,
    PaintInvalidationClean,
    InPrePaint,
    PrePaintClean,

[flackr, 2017/01/18 21:38:05]

Oops, you are right, this function seems to advance the lifecycle just past the
compositing update which should get the inputs clean - maybe also DCHECK this?

 
   LayoutObject* elementLayoutObject = layoutObject();
   if (!elementLayoutObject)