Force compositing inputs to be clean for getBoundingClientRect

third_party/WebKit/Source/core/dom/Element.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2001 Peter Kelly (pmk@post.com)
  *           (C) 2001 Dirk Mueller (mueller@kde.org)
  *           (C) 2007 David Smith (catfish.man@gmail.com)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2012, 2013 Apple Inc.
  * All rights reserved.
  *           (C) 2007 Eric Seidel (eric@webkit.org)
  *
@@ skipping 1102 matching lines @@
   IntRect rect(0, 0, viewportSize.width(), viewportSize.height());
   // We don't use absoluteBoundingBoxRect() because it can return an IntRect
   // larger the actual size by 1px. crbug.com/470503
   rect.intersect(document().view()->contentsToViewport(
       roundedIntRect(layoutObject()->absoluteBoundingBoxFloatRect())));
   return rect;
 }
 
 void Element::clientQuads(Vector<FloatQuad>& quads) {
   document().updateStyleAndLayoutIgnorePendingStylesheetsForNode(this);
+  FrameView* view = document().view();

[flackr, 2017/01/18 21:11:10]

nit: We tend to use the following style to scope conditionally used optional
variables
if (FrameView* view = document().view())
  ... code which uses view

[smcgruer, 2017/01/18 21:17:13]

Done.

+  if (view)
+    view->updateLifecycleToCompositingCleanPlusScrolling();

[flackr, 2017/01/18 21:11:10]

Was this call necessary? Does updateAllLifecyclePhasesExceptPaint not get the
lifecycle past compositing inputs?

[smcgruer, 2017/01/18 21:17:13]

I was aiming for minimal lifecycle update. updateAllLifecyclePhasesExceptPaint()
should work the same, except it will also do the following after
CompositingClean:

    InPaintInvalidation,
    PaintInvalidationClean,
    InPrePaint,
    PrePaintClean,

[flackr, 2017/01/18 21:38:05]

Oops, you are right, this function seems to advance the lifecycle just past the
compositing update which should get the inputs clean - maybe also DCHECK this?

 
   LayoutObject* elementLayoutObject = layoutObject();
   if (!elementLayoutObject)
     return;
 
   if (isSVGElement() && !elementLayoutObject->isSVGRoot()) {
     // Get the bounding rectangle from the SVG model.
     if (toSVGElement(this)->isSVGGraphicsElement())
       quads.push_back(elementLayoutObject->localToAbsoluteQuad(
           elementLayoutObject->objectBoundingBox()));
@@ skipping 2997 matching lines @@
 }
 
 DEFINE_TRACE_WRAPPERS(Element) {
   if (hasRareData()) {
     visitor->traceWrappers(elementRareData());
   }
   ContainerNode::traceWrappers(visitor);
 }
 
 }  // namespace blink