Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Issue 2647493004: [foozzie] Use correct ignition baseline (Closed)

Created:
3 years, 11 months ago by Michael Achenbach
Modified:
3 years, 11 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[foozzie] Use correct ignition baseline Also switch on validate asm in all configuration to zero out any comparisons. BUG=chromium:673246 NOTRY=true TBR=mstarzinger@chromium.org, rmcilroy@chromium.org Review-Url: https://codereview.chromium.org/2647493004 Cr-Commit-Position: refs/heads/master@{#42569} Committed: https://chromium.googlesource.com/v8/v8/+/24b9fc3a9a42977f58c872d4d99cce92e232650c

Patch Set 1 #

Patch Set 2 : validate asm #

Patch Set 3 : Clean up other configs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -9 lines) Patch
M tools/foozzie/v8_foozzie.py View 1 2 1 chunk +6 lines, -9 lines 0 comments Download

Messages

Total messages: 17 (10 generated)
Michael Achenbach
TBR
3 years, 11 months ago (2017-01-19 12:16:35 UTC) #5
rmcilroy
LGTM, thanks.
3 years, 11 months ago (2017-01-19 12:27:58 UTC) #6
Michael Starzinger
LGTM.
3 years, 11 months ago (2017-01-19 12:35:07 UTC) #7
Michael Starzinger
LGTM.
3 years, 11 months ago (2017-01-19 12:35:08 UTC) #8
Michael Achenbach
TBR - I now also switched on validate-asm in all configurations. Like that we get ...
3 years, 11 months ago (2017-01-20 15:32:09 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2647493004/40001
3 years, 11 months ago (2017-01-20 15:32:53 UTC) #14
commit-bot: I haz the power
3 years, 11 months ago (2017-01-20 15:35:12 UTC) #17
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/v8/v8/+/24b9fc3a9a42977f58c872d4d99cce92e23...

Powered by Google App Engine
This is Rietveld 408576698