Stop requiring a reader in MultibufferDataSource::SetBitrateTask()

Stop requiring a reader in MultibufferDataSource::SetBitrateTask()

Callers of MultibufferDataSource::SetBitrate() must not be required to
be aware of whether or not there is a |reader_| available, because
that's internal MultibufferDataSource state that changes for several
reasons, some of which aren't necessarily visible to the client calling
SetBitrate(), e.g., OnBufferingHaveEnough().

Note that UpdateBufferSizes(), called from SetBitrate(), handles the
case of a null |reader_| gracefully.

Review-Url: https://codereview.chromium.org/2647483003
Cr-Commit-Position: refs/heads/master@{#444867}
Committed: https://chromium.googlesource.com/chromium/src/+/231e833f8aab516b124544a01e8a4e8441ac47f0

[wdzierzanowski, 2017-01-19 08:08:33]

Description was changed from

==========
Stop requiring a reader in MultibufferDataSource::SetBitrateTask()

Callers of MultibufferDataSource::SetBitrate() must not be required to
be aware of whether or not there is a |reader_| available, because
that's internal MultibufferDataSource state that changes for several
reasons, some of which aren't necessarily visible to the client calling
SetBitrate(), e.g., OnBufferingHaveEnough().

Note that UpdateBufferSizes(), called from SetBitrate(), handles the
case of a null |reader_| gracefully.
==========

to

==========
Stop requiring a reader in MultibufferDataSource::SetBitrateTask()

Callers of MultibufferDataSource::SetBitrate() must not be required to
be aware of whether or not there is a |reader_| available, because
that's internal MultibufferDataSource state that changes for several
reasons, some of which aren't necessarily visible to the client calling
SetBitrate(), e.g., OnBufferingHaveEnough().

Note that UpdateBufferSizes(), called from SetBitrate(), handles the
case of a null |reader_| gracefully.
==========

[wdzierzanowski, 2017-01-19 08:08:33]

wdzierzanowski@opera.com changed reviewers:
+ hubbe@chromium.org

[wdzierzanowski, 2017-01-19 08:17:17]

Hello hubbe@, this is a small thing, never seen it causing an issue in Chrome,
but the assertion does sometimes fail in Opera, where the SetBitrate() call can
arrive a bit later than in Chrome. PTAL.

[hubbe, 2017-01-19 17:10:27]

lgtm

[wdzierzanowski, 2017-01-19 20:57:54]

Thanks!

[wdzierzanowski, 2017-01-19 20:58:00]

The CQ bit was checked by wdzierzanowski@opera.com

[commit-bot: I haz the power, 2017-01-19 20:58:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-19 22:41:05]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1484859480790360, "parent_rev":
"bf6c6a31bafed2f7bc5ed6083e32b21956152221", "commit_rev":
"231e833f8aab516b124544a01e8a4e8441ac47f0"}

[commit-bot: I haz the power, 2017-01-19 22:41:37]

Description was changed from

==========
Stop requiring a reader in MultibufferDataSource::SetBitrateTask()

Callers of MultibufferDataSource::SetBitrate() must not be required to
be aware of whether or not there is a |reader_| available, because
that's internal MultibufferDataSource state that changes for several
reasons, some of which aren't necessarily visible to the client calling
SetBitrate(), e.g., OnBufferingHaveEnough().

Note that UpdateBufferSizes(), called from SetBitrate(), handles the
case of a null |reader_| gracefully.
==========

to

==========
Stop requiring a reader in MultibufferDataSource::SetBitrateTask()

Callers of MultibufferDataSource::SetBitrate() must not be required to
be aware of whether or not there is a |reader_| available, because
that's internal MultibufferDataSource state that changes for several
reasons, some of which aren't necessarily visible to the client calling
SetBitrate(), e.g., OnBufferingHaveEnough().

Note that UpdateBufferSizes(), called from SetBitrate(), handles the
case of a null |reader_| gracefully.

Review-Url: https://codereview.chromium.org/2647483003
Cr-Commit-Position: refs/heads/master@{#444867}
Committed:
https://chromium.googlesource.com/chromium/src/+/231e833f8aab516b124544a01e8a...
==========

[commit-bot: I haz the power, 2017-01-19 22:41:38]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/231e833f8aab516b124544a01e8a...