Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 2647443004: Add SVGResources helper for resource-bounds invalidation (Closed)

Created:
3 years, 11 months ago by fs
Modified:
3 years, 11 months ago
Reviewers:
pdr., Stephen Chennney
CC:
fs, blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, krit, eae+blinkwatch, f(malita), gyuyoung2, jchaffraix+rendering, kouhei+svg_chromium.org, leviw+renderwatch, pdr+svgwatchlist_chromium.org, pdr+renderingwatchlist_chromium.org, rwlbuis, Stephen Chennney, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add SVGResources helper for resource-bounds invalidation Add a new helper method removeClientFromCacheAffectingObjectBounds to SVGResources to better describe the intention of code that performs this operation (removeFromCacheAndInvalidateDependencies.) It also makes LayoutSVGResourceContainer not depend on its derived classes. Also make use of it in the generic SVGResources::removeClientFromCache. Review-Url: https://codereview.chromium.org/2647443004 Cr-Commit-Position: refs/heads/master@{#444811} Committed: https://chromium.googlesource.com/chromium/src/+/800c77a0e95403c64205c1c8760272c159533936

Patch Set 1 #

Patch Set 2 : Default was actually true... #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -23 lines) Patch
M third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceContainer.cpp View 2 chunks +1 line, -12 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/SVGResources.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/SVGResources.cpp View 2 chunks +14 lines, -11 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
fs
3 years, 11 months ago (2017-01-19 18:02:52 UTC) #8
Stephen Chennney
lgtm
3 years, 11 months ago (2017-01-19 19:06:05 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2647443004/20001
3 years, 11 months ago (2017-01-19 19:06:54 UTC) #11
commit-bot: I haz the power
3 years, 11 months ago (2017-01-19 19:13:55 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/800c77a0e95403c64205c1c87602...

Powered by Google App Engine
This is Rietveld 408576698