Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issue 2647423002: Roll buildtools cb12d6e864..8e94621c36 (Closed)

Created:
3 years, 11 months ago by brettw
Modified:
3 years, 11 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll buildtools cb12d6e864..8e94621c36 In order to roll GN b4dbf044c5..f13158d3c5 (r443809:r445411) and pick up the following changes: adbf15668dc1 GN: Add optional default_args variable to .gn. bb57bea1642b Validate GN substitutions in args and rsp files. 6c0a0762e465 Remove obsolete GN check.md documentation. de19976ca12b Consolidate Xcode Project Setup 6d75d94d4a41 gn: fix build with GCC 5 TBR=dpranke@chromium.org Review-Url: https://codereview.chromium.org/2647423002 Cr-Commit-Position: refs/heads/master@{#445471} Committed: https://chromium.googlesource.com/chromium/src/+/ed8d8325bf6b78433c13c01d0972fc491b6555a3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
brettw
3 years, 11 months ago (2017-01-23 19:20:49 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2647423002/1
3 years, 11 months ago (2017-01-23 19:21:20 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/ed8d8325bf6b78433c13c01d0972fc491b6555a3
3 years, 11 months ago (2017-01-23 20:37:12 UTC) #6
Dirk Pranke
3 years, 11 months ago (2017-01-23 22:48:46 UTC) #7
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698