Fix type error in analyzer test

Fix type error in analyzer test

Follow-up to CL https://codereview.chromium.org/2653683004

BUG=
R=lrn@google.com

Committed: https://github.com/dart-lang/sdk/commit/d17af0420cf93386201329744bdb1ea4165c8989

[Bill Hesse, 2017-01-25 11:50:05]

whesse@google.com changed reviewers:
+ lrn@google.com, scheglov@google.com

[Lasse Reichstein Nielsen, 2017-01-25 11:59:08]

lgtm

[Bill Hesse, 2017-01-25 11:59:39]

Description was changed from

==========
Fix type error in analyzer test

Follow-up to CL https://codereview.chromium.org/2653683004

BUG=
==========

to

==========
Fix type error in analyzer test

Follow-up to CL https://codereview.chromium.org/2653683004

BUG=
R=lrn@google.com

Committed:
https://github.com/dart-lang/sdk/commit/d17af0420cf93386201329744bdb1ea4165c8989
==========

[Bill Hesse, 2017-01-25 11:59:40]

Committed patchset #1 (id:1) manually as
d17af0420cf93386201329744bdb1ea4165c8989 (presubmit successful).

[scheglov, 2017-01-25 15:07:17]

I guess lgtm, but why?
Was it causing build / test problems?

[Bill Hesse, 2017-01-25 15:12:32]

On 2017/01/25 15:07:17, scheglov wrote:
> I guess lgtm, but why?
> Was it causing build / test problems?

It was an analyzer warning.  The template type T and the "is FileState" guard
couldn't be
combined (since T could be a subclass of FileState?) so the static type was
unknown (or object).

Now the static type after the guard is FileState.

[scheglov, 2017-01-25 15:16:28]

On 2017/01/25 15:12:32, Bill Hesse wrote:
> On 2017/01/25 15:07:17, scheglov wrote:
> > I guess lgtm, but why?
> > Was it causing build / test problems?
> 
> It was an analyzer warning.  The template type T and the "is FileState" guard
> couldn't be
> combined (since T could be a subclass of FileState?) so the static type was
> unknown (or object).
> 
> Now the static type after the guard is FileState.

Thank you!

[Leaf, 2017-01-25 19:03:00]

leafp@google.com changed reviewers:
+ leafp@google.com

[Leaf, 2017-01-25 19:03:00]

https://codereview.chromium.org/2647363005/diff/1/pkg/analyzer/test/src/dart/...
File pkg/analyzer/test/src/dart/analysis/file_state_test.dart (right):

https://codereview.chromium.org/2647363005/diff/1/pkg/analyzer/test/src/dart/...
pkg/analyzer/test/src/dart/analysis/file_state_test.dart:692: return
files.where((Object file) {
Is this non-strong mode analysis?  This should work in strong mode.

[scheglov, 2017-01-25 19:06:02]

https://codereview.chromium.org/2647363005/diff/1/pkg/analyzer/test/src/dart/...
File pkg/analyzer/test/src/dart/analysis/file_state_test.dart (right):

https://codereview.chromium.org/2647363005/diff/1/pkg/analyzer/test/src/dart/...
pkg/analyzer/test/src/dart/analysis/file_state_test.dart:692: return
files.where((Object file) {
On 2017/01/25 19:03:00, Leaf wrote:
> Is this non-strong mode analysis?  This should work in strong mode.

FWIW, resolution works, so "file.uri" is resolved.
But Analysis Server says that the static type of "file" is "T", and code
completion does not work.