Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 2653683004: Stop using SDK summary bundle. Analyze dart:xxx as any other libraries. (Closed)

Created:
3 years, 11 months ago by scheglov
Modified:
3 years, 11 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Stop using SDK summary bundle. Analyze dart:xxx as any other libraries. Unfortunately this makes runnings tests about 30% slower :-( I suspect that's because we have to build unlinked and linked summaries for SDK libraries again and again for every tiny test. R=brianwilkerson@google.com, paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/fcd5f16d100937264f8949423fb0c6d4cbe0286d

Patch Set 1 #

Patch Set 2 : Restore optional SDK bundle. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+181 lines, -145 lines) Patch
M pkg/analysis_server/lib/src/services/completion/dart/combinator_contributor.dart View 1 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/analysis_server/lib/src/services/correction/fix_internal.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/abstract_context.dart View 1 4 chunks +6 lines, -6 lines 0 comments Download
M pkg/analysis_server/test/context_manager_driver_test.dart View 1 1 chunk +0 lines, -15 lines 0 comments Download
M pkg/analysis_server/test/domain_diagnostic_test.dart View 1 1 chunk +1 line, -6 lines 0 comments Download
M pkg/analysis_server/test/services/completion/dart/imported_reference_contributor_test.dart View 1 3 chunks +2 lines, -3 lines 0 comments Download
M pkg/analysis_server/test/services/completion/dart/optype_test.dart View 1 3 chunks +7 lines, -3 lines 0 comments Download
M pkg/analysis_server/test/services/correction/fix_test.dart View 1 4 chunks +63 lines, -3 lines 0 comments Download
M pkg/analysis_server/test/services/refactoring/move_file_test.dart View 1 3 chunks +2 lines, -3 lines 0 comments Download
M pkg/analysis_server/test/services/search/search_engine2_test.dart View 1 4 chunks +5 lines, -3 lines 0 comments Download
M pkg/analyzer/lib/src/dart/analysis/driver.dart View 1 6 chunks +23 lines, -41 lines 0 comments Download
M pkg/analyzer/lib/src/dart/analysis/file_state.dart View 5 chunks +17 lines, -32 lines 0 comments Download
M pkg/analyzer/test/src/dart/analysis/driver_test.dart View 3 chunks +8 lines, -3 lines 0 comments Download
M pkg/analyzer/test/src/dart/analysis/file_state_test.dart View 11 chunks +36 lines, -20 lines 0 comments Download
M pkg/analyzer/test/src/dart/analysis/search_test.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M pkg/front_end/lib/src/incremental_resolved_ast_generator_impl.dart View 1 2 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
scheglov
3 years, 11 months ago (2017-01-24 21:07:28 UTC) #1
Paul Berry
lgtm
3 years, 11 months ago (2017-01-24 21:16:27 UTC) #2
Brian Wilkerson
lgtm, but I'm just wondering... Can we make the use of summaries optional? Use them ...
3 years, 11 months ago (2017-01-24 21:38:47 UTC) #3
scheglov
On 2017/01/24 21:38:47, Brian Wilkerson wrote: > lgtm, but I'm just wondering... > > Can ...
3 years, 11 months ago (2017-01-25 02:30:42 UTC) #4
scheglov
3 years, 11 months ago (2017-01-25 02:32:33 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
fcd5f16d100937264f8949423fb0c6d4cbe0286d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698