[Download Home] Fix for 0 seconds remaining

[Download Home] Fix for 0 seconds remaining

Download backend is not able to compute the time remaining when download
is started/paused/resumed. In those cases, currently it returns 0 which
causes confusion to the UI. This CL proposes to return -1 in those cases
and which can be easily distinguished from a valid 0 seconds remaining
message.

BUG=682865
Review-Url: https://codereview.chromium.org/2647343005
Cr-Commit-Position: refs/heads/master@{#446106}
Committed: https://chromium.googlesource.com/chromium/src/+/0a1f62791cf3be6eaca850d90518fe2436b5a94c

[shaktisahu, 2017-01-25 16:36:26]

shaktisahu@chromium.org changed reviewers:
+ dfalcantara@chromium.org

[shaktisahu, 2017-01-25 16:36:26]

PTAL

[gone, 2017-01-25 18:05:37]

dfalcantara@chromium.org changed reviewers:
+ qinmin@chromium.org

[gone, 2017-01-25 18:05:37]

Backend change -> Min.  I'll check this when he approves it.

[qinmin, 2017-01-25 18:21:51]

lgtm % comments

https://codereview.chromium.org/2647343005/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java
(right):

https://codereview.chromium.org/2647343005/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java:295:
contentText = mContext.getResources().getString(R.string.download_started);
nit: you can save one else block here, just 
else {
  contentText = (timeRemainingInMillis < 0) ? 
mContext.getResources().getString(R.string.download_st
     arted) : formatRemainingTime(mContext, timeRemainingInMillis)
}

https://codereview.chromium.org/2647343005/diff/1/chrome/browser/android/down...
File chrome/browser/android/download/download_manager_service.cc (right):

https://codereview.chromium.org/2647343005/diff/1/chrome/browser/android/down...
chrome/browser/android/download/download_manager_service.cc:112:
time_remaining_known ? time_delta.InMilliseconds() : -1);
define a constant here: kUnknownRemainingTime, e.g

[gone, 2017-01-25 19:13:14]

lgtm % Min's comments.

[shaktisahu, 2017-01-25 19:24:56]

https://codereview.chromium.org/2647343005/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java
(right):

https://codereview.chromium.org/2647343005/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java:295:
contentText = mContext.getResources().getString(R.string.download_started);
On 2017/01/25 18:21:51, qinmin wrote:
> nit: you can save one else block here, just 
> else {
>   contentText = (timeRemainingInMillis < 0) ? 
> mContext.getResources().getString(R.string.download_st
>      arted) : formatRemainingTime(mContext, timeRemainingInMillis)
> }

Done.

https://codereview.chromium.org/2647343005/diff/1/chrome/browser/android/down...
File chrome/browser/android/download/download_manager_service.cc (right):

https://codereview.chromium.org/2647343005/diff/1/chrome/browser/android/down...
chrome/browser/android/download/download_manager_service.cc:112:
time_remaining_known ? time_delta.InMilliseconds() : -1);
On 2017/01/25 18:21:51, qinmin wrote:
> define a constant here: kUnknownRemainingTime, e.g

Done.

[shaktisahu, 2017-01-25 19:25:38]

The CQ bit was checked by shaktisahu@chromium.org

[shaktisahu, 2017-01-25 19:25:39]

The patchset sent to the CQ was uploaded after l-g-t-m from qinmin@chromium.org,
dfalcantara@chromium.org
Link to the patchset: https://codereview.chromium.org/2647343005/#ps20001
(title: "qinmin@ comments")

[commit-bot: I haz the power, 2017-01-25 19:26:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-25 20:26:22]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1485372338765970,
"parent_rev": "069143f29ed0337786dda1c61e1db426be3879a4", "commit_rev":
"0a1f62791cf3be6eaca850d90518fe2436b5a94c"}

[commit-bot: I haz the power, 2017-01-25 20:26:55]

Description was changed from

==========
[Download Home] Fix for 0 seconds remaining

Download backend is not able to compute the time remaining when download
is started/paused/resumed. In those cases, currently it returns 0 which
causes confusion to the UI. This CL proposes to return -1 in those cases
and which can be easily distinguished from a valid 0 seconds remaining
message.

BUG=682865
==========

to

==========
[Download Home] Fix for 0 seconds remaining

Download backend is not able to compute the time remaining when download
is started/paused/resumed. In those cases, currently it returns 0 which
causes confusion to the UI. This CL proposes to return -1 in those cases
and which can be easily distinguished from a valid 0 seconds remaining
message.

BUG=682865

Review-Url: https://codereview.chromium.org/2647343005
Cr-Commit-Position: refs/heads/master@{#446106}
Committed:
https://chromium.googlesource.com/chromium/src/+/0a1f62791cf3be6eaca850d90518...
==========

[commit-bot: I haz the power, 2017-01-25 20:26:56]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/0a1f62791cf3be6eaca850d90518...