Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Unified Diff: chrome/browser/safe_browsing/services_delegate_impl.cc

Issue 2647323009: Add extended reporting level in the update request (Closed)
Patch Set: Add tests for ERL Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/safe_browsing/services_delegate_impl.h ('k') | components/safe_browsing_db/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/safe_browsing/services_delegate_impl.cc
diff --git a/chrome/browser/safe_browsing/services_delegate_impl.cc b/chrome/browser/safe_browsing/services_delegate_impl.cc
index e239d89c548adb633b24973f65817183ca27ec70..186d3431bce07fe2d09f67839c7bc40fdd1b7024 100644
--- a/chrome/browser/safe_browsing/services_delegate_impl.cc
+++ b/chrome/browser/safe_browsing/services_delegate_impl.cc
@@ -54,6 +54,19 @@ void ServicesDelegateImpl::InitializeCsdService(
#endif // defined(SAFE_BROWSING_CSD)
}
+ExtendedReportingLevel ServicesDelegateImpl::GetMayBeExtendedReportingLevel()
+ const {
+ if (safe_browsing_service_->maybe_enabled_extended_reporting_by_prefs()) {
Jialiu Lin 2017/01/25 02:03:29 nit: It is possible that both maybe_enabled_extend
vakh (use Gerrit instead) 2017/01/25 02:13:41 Done.
+ // If extended reporting is enabled, report that so that we can track its
+ // usage better for deprecation.
+ return SBER_LEVEL_LEGACY;
+ }
+ if (safe_browsing_service_->maybe_enabled_scout_reporting_by_prefs()) {
+ return SBER_LEVEL_SCOUT;
+ }
+ return SBER_LEVEL_OFF;
+}
+
const scoped_refptr<SafeBrowsingDatabaseManager>&
ServicesDelegateImpl::v4_local_database_manager() const {
return v4_local_database_manager_;
@@ -62,8 +75,10 @@ ServicesDelegateImpl::v4_local_database_manager() const {
void ServicesDelegateImpl::Initialize() {
DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
- v4_local_database_manager_ =
- V4LocalDatabaseManager::Create(SafeBrowsingService::GetBaseFilename());
+ v4_local_database_manager_ = V4LocalDatabaseManager::Create(
+ SafeBrowsingService::GetBaseFilename(),
+ base::Bind(&ServicesDelegateImpl::GetMayBeExtendedReportingLevel,
+ base::Unretained(this)));
download_service_.reset(
(services_creator_ &&
« no previous file with comments | « chrome/browser/safe_browsing/services_delegate_impl.h ('k') | components/safe_browsing_db/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698