Workaround platform differences in svg/text/combining-character-queries.html

Workaround platform differences in svg/text/combining-character-queries.html

MacOS has consistent differences[1] in the glyphs of "ffi" with diacritics
and the default cursive font (Apple Chancery). On some machines,
two diacritics are drawn whereas on others only one is. This patch works
around this difference by removing the ffi glyph from the test when the
cursive family is used.

Similarly[2], Linux has consistent differences in the space width
preceding a missing glyph. On some machines, it is wider than others.
This patch works around this difference by removing the space glyph in
favor of a period.

[1,2] http://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_tests&showExpectations=true&tests=svg%2Ftext%2Fcombining-character-queries.html

BUG=669693
Review-Url: https://codereview.chromium.org/2647293005
Cr-Commit-Position: refs/heads/master@{#445815}
Committed: https://chromium.googlesource.com/chromium/src/+/eb52fcf8c84eb033f63d2839eb8805eb9ec137fe

[pdr., 2017-01-24 05:16:27]

The CQ bit was checked by pdr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-24 05:16:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[pdr., 2017-01-24 05:32:25]

The CQ bit was unchecked by pdr@chromium.org

[pdr., 2017-01-24 18:22:44]

pdr@chromium.org changed reviewers:
+ fs@opera.com

[pdr., 2017-01-24 18:24:00]

Not a huge fan of this approach but I don't know of a better way to handle these
issues while still keeping the test coverage.

[pdr., 2017-01-24 18:24:04]

The CQ bit was checked by pdr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-24 18:24:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[fs, 2017-01-24 18:28:46]

On 2017/01/24 at 18:24:00, pdr wrote:
> Not a huge fan of this approach but I don't know of a better way to handle
these issues while still keeping the test coverage.

Doesn't seem unreasonable to me. LGTM.

[pdr., 2017-01-24 18:31:11]

The CQ bit was unchecked by pdr@chromium.org

[pdr., 2017-01-24 20:54:51]

The CQ bit was checked by pdr@chromium.org

[commit-bot: I haz the power, 2017-01-24 20:55:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-24 21:20:56]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1485291291578960,
"parent_rev": "f5966465d96bf16d576399c85d0199944d7b420d", "commit_rev":
"eb52fcf8c84eb033f63d2839eb8805eb9ec137fe"}

[commit-bot: I haz the power, 2017-01-24 21:21:32]

Description was changed from

==========
Workaround platform differences in svg/text/combining-character-queries.html

MacOS has consistent differences[1] in the glyphs of "ffi" with diacritics
and the default cursive font (Apple Chancery). On some machines,
two diacritics are drawn whereas on others only one is. This patch works
around this difference by removing the ffi glyph from the test when the
cursive family is used.

Similarly[2], Linux has consistent differences in the space width
preceding a missing glyph. On some machines, it is wider than others.
This patch works around this difference by removing the space glyph in
favor of a period.

[1,2]
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=...

BUG=669693
==========

to

==========
Workaround platform differences in svg/text/combining-character-queries.html

MacOS has consistent differences[1] in the glyphs of "ffi" with diacritics
and the default cursive font (Apple Chancery). On some machines,
two diacritics are drawn whereas on others only one is. This patch works
around this difference by removing the ffi glyph from the test when the
cursive family is used.

Similarly[2], Linux has consistent differences in the space width
preceding a missing glyph. On some machines, it is wider than others.
This patch works around this difference by removing the space glyph in
favor of a period.

[1,2]
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=...

BUG=669693

Review-Url: https://codereview.chromium.org/2647293005
Cr-Commit-Position: refs/heads/master@{#445815}
Committed:
https://chromium.googlesource.com/chromium/src/+/eb52fcf8c84eb033f63d2839eb88...
==========

[commit-bot: I haz the power, 2017-01-24 21:21:34]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/eb52fcf8c84eb033f63d2839eb88...