Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 2647293002: Disable <meta> tag in a shadow tree (Closed)

Created:
3 years, 11 months ago by hayato
Modified:
3 years, 11 months ago
Reviewers:
kochi
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink, kenneth.christiansen
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable <meta> tag in a shadow tree The spec is: - http://w3c.github.io/webcomponents/spec/shadow/#inertness-of-html-elements-in-a-shadow-tree - https://html.spec.whatwg.org/#meta Though HTML Standard has not fully explained how <meta> tag should work in a shadow tree yet, our consensus is <meta> should not work in a shadow tree. This CL didn't add a new test, just removing one expectation file of a web platform test. We would have tests for meta tag in web platform tests. BUG=676092 Review-Url: https://codereview.chromium.org/2647293002 Cr-Commit-Position: refs/heads/master@{#445373} Committed: https://chromium.googlesource.com/chromium/src/+/5dc22a61fc8e68b59cc7e82d2f616daa185c6507

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -6 lines) Patch
D third_party/WebKit/LayoutTests/external/wpt/html/semantics/document-metadata/the-meta-element/pragma-directives/attr-meta-http-equiv-refresh/not-in-shadow-tree-expected.txt View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLMetaElement.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (8 generated)
hayato
PTAL
3 years, 11 months ago (2017-01-23 08:57:25 UTC) #4
kochi
BUG# link seems wrong? Could you point to the original bug?
3 years, 11 months ago (2017-01-23 09:39:40 UTC) #5
kochi
On 2017/01/23 09:39:40, kochi wrote: > BUG# link seems wrong? > Could you point to ...
3 years, 11 months ago (2017-01-23 09:42:14 UTC) #6
kochi
LGTM
3 years, 11 months ago (2017-01-23 11:00:32 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2647293002/1
3 years, 11 months ago (2017-01-23 11:02:05 UTC) #11
commit-bot: I haz the power
3 years, 11 months ago (2017-01-23 15:15:16 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/5dc22a61fc8e68b59cc7e82d2f61...

Powered by Google App Engine
This is Rietveld 408576698