Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Unified Diff: third_party/WebKit/Source/core/editing/SelectionTemplate.h

Issue 2647283006: Removing HandleVisible enum from FrameSelection (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/SelectionTemplate.h
diff --git a/third_party/WebKit/Source/core/editing/SelectionTemplate.h b/third_party/WebKit/Source/core/editing/SelectionTemplate.h
index 1d48c2d2f59345c645916eee3ecaf428cbf02db8..78dd1843ac9af89260b2aed1c3e2d322019e171a 100644
--- a/third_party/WebKit/Source/core/editing/SelectionTemplate.h
+++ b/third_party/WebKit/Source/core/editing/SelectionTemplate.h
@@ -66,6 +66,7 @@ class CORE_EXPORT SelectionTemplate final {
Builder& setGranularity(TextGranularity);
Builder& setHasTrailingWhitespace(bool);
Builder& setIsDirectional(bool);
+ Builder& setIsHandleVisible(bool);
yosin_UTC9 2017/01/25 04:01:09 Could you move this change to another patch with t
Changwan Ryu 2017/01/25 09:29:47 amaralp@, could you work on this as well? I'll wai
private:
SelectionTemplate m_selection;
@@ -87,6 +88,7 @@ class CORE_EXPORT SelectionTemplate final {
TextGranularity granularity() const { return m_granularity; }
bool hasTrailingWhitespace() const { return m_hasTrailingWhitespace; }
bool isDirectional() const { return m_isDirectional; }
+ bool isHandleVisible() const { return m_isHandleVisible; }
bool isNone() const { return m_base.isNull(); }
// Returns true if |this| selection holds valid values otherwise it causes
@@ -115,6 +117,7 @@ class CORE_EXPORT SelectionTemplate final {
TextGranularity m_granularity = CharacterGranularity;
bool m_hasTrailingWhitespace = false;
bool m_isDirectional = false;
+ bool m_isHandleVisible = false;
#if DCHECK_IS_ON()
uint64_t m_domTreeVersion;
#endif

Powered by Google App Engine
This is Rietveld 408576698