Removing HandleVisible enum from FrameSelection

third_party/WebKit/Source/core/editing/SelectionTemplate.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef SelectionTemplate_h
 #define SelectionTemplate_h
 
 #include "base/macros.h"
 #include "core/CoreExport.h"
 #include "core/editing/EphemeralRange.h"
@@ skipping 48 matching lines @@
     // Note: This function should be used only in "core/editing/commands".
     // TODO(yosin): Once all we get rid of all call sites, we remove this.
     Builder& setBaseAndExtentDeprecated(
         const PositionTemplate<Strategy>& base,
         const PositionTemplate<Strategy>& extent);
 
     Builder& setAffinity(TextAffinity);
     Builder& setGranularity(TextGranularity);
     Builder& setHasTrailingWhitespace(bool);
     Builder& setIsDirectional(bool);
+    Builder& setIsHandleVisible(bool);

[yosin_UTC9, 2017/01/25 04:01:09]

Could you move this change to another patch with test cases in
"SelectionTemplateTest.cpp"?

BTW, it seems changwang@ also does same change. Please coordinate the work.

[Changwan Ryu, 2017/01/25 09:29:47]

amaralp@, could you work on this as well? I'll wait for your CLs to land first.

 
    private:
     SelectionTemplate m_selection;
 
     DISALLOW_COPY_AND_ASSIGN(Builder);
   };
 
   SelectionTemplate(const SelectionTemplate& other);
   SelectionTemplate();
 
   SelectionTemplate& operator=(const SelectionTemplate&) = default;
 
   bool operator==(const SelectionTemplate&) const;
   bool operator!=(const SelectionTemplate&) const;
 
   const PositionTemplate<Strategy>& base() const;
   const PositionTemplate<Strategy>& extent() const;
   TextAffinity affinity() const { return m_affinity; }
   TextGranularity granularity() const { return m_granularity; }
   bool hasTrailingWhitespace() const { return m_hasTrailingWhitespace; }
   bool isDirectional() const { return m_isDirectional; }
+  bool isHandleVisible() const { return m_isHandleVisible; }
   bool isNone() const { return m_base.isNull(); }
 
   // Returns true if |this| selection holds valid values otherwise it causes
   // assertion failure.
   bool assertValid() const;
   bool assertValidFor(const Document&) const;
 
   DEFINE_INLINE_TRACE() {
     visitor->trace(m_base);
     visitor->trace(m_extent);
   }
 
   void printTo(std::ostream*, const char* type) const;
 #ifndef NDEBUG
   void showTreeForThis() const;
 #endif
 
  private:
   friend class SelectionEditor;
 
   Document* document() const;
 
   PositionTemplate<Strategy> m_base;
   PositionTemplate<Strategy> m_extent;
   TextAffinity m_affinity = TextAffinity::Downstream;
   TextGranularity m_granularity = CharacterGranularity;
   bool m_hasTrailingWhitespace = false;
   bool m_isDirectional = false;
+  bool m_isHandleVisible = false;
 #if DCHECK_IS_ON()
   uint64_t m_domTreeVersion;
 #endif
 };
 
 extern template class CORE_EXTERN_TEMPLATE_EXPORT
     SelectionTemplate<EditingStrategy>;
 extern template class CORE_EXTERN_TEMPLATE_EXPORT
     SelectionTemplate<EditingInFlatTreeStrategy>;
 
 using SelectionInDOMTree = SelectionTemplate<EditingStrategy>;
 using SelectionInFlatTree = SelectionTemplate<EditingInFlatTreeStrategy>;
 
 CORE_EXPORT std::ostream& operator<<(std::ostream&, const SelectionInDOMTree&);
 CORE_EXPORT std::ostream& operator<<(std::ostream&, const SelectionInFlatTree&);
 
 }  // namespace blink
 
 #endif  // SelectionTemplate_h