Chromium Code Reviews| Index: third_party/WebKit/Source/core/editing/FrameSelection.h |
| diff --git a/third_party/WebKit/Source/core/editing/FrameSelection.h b/third_party/WebKit/Source/core/editing/FrameSelection.h |
| index 79291e35354cd13c5d231bfe4f7612b68b970b16..0c1ea6ad14a2f29b3a2a10e09d2cf2a71c5c3cbf 100644 |
| --- a/third_party/WebKit/Source/core/editing/FrameSelection.h |
| +++ b/third_party/WebKit/Source/core/editing/FrameSelection.h |
| @@ -89,7 +89,6 @@ class CORE_EXPORT FrameSelection final |
| DoNotUpdateAppearance = 1 << 4, |
| DoNotClearStrategy = 1 << 5, |
| DoNotAdjustInFlatTree = 1 << 6, |
| - HandleVisible = 1 << 7, |
| }; |
| // Union of values in SetSelectionOption and EUserTriggered |
| typedef unsigned SetSelectionOptions; |
| @@ -136,12 +135,14 @@ class CORE_EXPORT FrameSelection final |
| // TODO(yosin): We should use |SelectionInDOMTree| version instead of |
| // |VisibleSelection| version. |
| void setSelection(const VisibleSelection&, |
| + bool isHandleVisible = false, |
|
yosin_UTC9
2017/01/25 04:01:09
Since we still have |HandleVisibility|. Can we use
|
| SetSelectionOptions = CloseTyping | ClearTypingStyle, |
| CursorAlignOnScroll = CursorAlignOnScroll::IfNeeded, |
| TextGranularity = CharacterGranularity); |
| // TODO(yosin): We should use |SelectionInFlatTree| version instead of |
| // |VisibleSelectionInFlatTree| version. |
| void setSelection(const VisibleSelectionInFlatTree&, |
| + bool isHandleVisible = false, |
| SetSelectionOptions = CloseTyping | ClearTypingStyle, |
| CursorAlignOnScroll = CursorAlignOnScroll::IfNeeded, |
| TextGranularity = CharacterGranularity); |
| @@ -295,6 +296,7 @@ class CORE_EXPORT FrameSelection final |
| template <typename Strategy> |
| void setSelectionAlgorithm(const VisibleSelectionTemplate<Strategy>&, |
| + bool isHandleVisible, |
| SetSelectionOptions, |
| CursorAlignOnScroll, |
| TextGranularity); |