Removing HandleVisible enum from FrameSelection

third_party/WebKit/Source/core/editing/FrameSelection.h

 /*
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights
  * reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 71 matching lines @@
 
   enum EAlteration { AlterationMove, AlterationExtend };
   enum SetSelectionOption {
     // 1 << 0 is reserved for EUserTriggered
     CloseTyping = 1 << 1,
     ClearTypingStyle = 1 << 2,
     DoNotSetFocus = 1 << 3,
     DoNotUpdateAppearance = 1 << 4,
     DoNotClearStrategy = 1 << 5,
     DoNotAdjustInFlatTree = 1 << 6,
-    HandleVisible = 1 << 7,
   };
   // Union of values in SetSelectionOption and EUserTriggered
   typedef unsigned SetSelectionOptions;
   static inline EUserTriggered selectionOptionsToUserTriggered(
       SetSelectionOptions options) {
     return static_cast<EUserTriggered>(options & UserTriggered);
   }
 
   bool isAvailable() const { return m_document; }
   // You should not call |document()| when |!isAvailable()|.
@@ skipping 26 matching lines @@
                     TextGranularity = CharacterGranularity);
 
   void setSelection(const SelectionInFlatTree&,
                     SetSelectionOptions = CloseTyping | ClearTypingStyle,
                     CursorAlignOnScroll = CursorAlignOnScroll::IfNeeded,
                     TextGranularity = CharacterGranularity);
 
   // TODO(yosin): We should use |SelectionInDOMTree| version instead of
   // |VisibleSelection| version.
   void setSelection(const VisibleSelection&,
+                    bool isHandleVisible = false,

[yosin_UTC9, 2017/01/25 04:01:09]

Since we still have |HandleVisibility|. Can we use it instead of |bool|
parameter?

                     SetSelectionOptions = CloseTyping | ClearTypingStyle,
                     CursorAlignOnScroll = CursorAlignOnScroll::IfNeeded,
                     TextGranularity = CharacterGranularity);
   // TODO(yosin): We should use |SelectionInFlatTree| version instead of
   // |VisibleSelectionInFlatTree| version.
   void setSelection(const VisibleSelectionInFlatTree&,
+                    bool isHandleVisible = false,
                     SetSelectionOptions = CloseTyping | ClearTypingStyle,
                     CursorAlignOnScroll = CursorAlignOnScroll::IfNeeded,
                     TextGranularity = CharacterGranularity);
   bool setSelectedRange(
       const EphemeralRange&,
       TextAffinity,
       SelectionDirectionalMode = SelectionDirectionalMode::NonDirectional,
       FrameSelection::SetSelectionOptions = CloseTyping | ClearTypingStyle);
   void selectAll();
   void clear();
@@ skipping 133 matching lines @@
 
   // For |PaintControllerPaintTestForSlimmingPaintV1AndV2|.
   const DisplayItemClient& caretDisplayItemClientForTesting() const;
 
   // Note: We have |selectionInFlatTree()| for unit tests, we should
   // use |visibleSelection<EditingInFlatTreeStrategy>()|.
   const VisibleSelectionInFlatTree& selectionInFlatTree() const;
 
   template <typename Strategy>
   void setSelectionAlgorithm(const VisibleSelectionTemplate<Strategy>&,
+                             bool isHandleVisible,
                              SetSelectionOptions,
                              CursorAlignOnScroll,
                              TextGranularity);
 
   void respondToNodeModification(Node&,
                                  bool baseRemoved,
                                  bool extentRemoved,
                                  bool startRemoved,
                                  bool endRemoved);
 
@@ skipping 51 matching lines @@
 
 }  // namespace blink
 
 #ifndef NDEBUG
 // Outside the WebCore namespace for ease of invocation from gdb.
 void showTree(const blink::FrameSelection&);
 void showTree(const blink::FrameSelection*);
 #endif
 
 #endif  // FrameSelection_h