Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(523)

Issue 2647273002: Remove ScopedVector from content::ZygoteMain() (Closed)

Created:
3 years, 11 months ago by leonhsl(Using Gerrit)
Modified:
3 years, 11 months ago
CC:
chromium-apps-reviews_chromium.org, chromium-reviews, darin-cc_chromium.org, extensions-reviews_chromium.org, jam, Avi (use Gerrit)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove ScopedVector from content::ZygoteMain() base::ScopedVector is deprecated, see bug. BUG=554289 TBR=bradnelson@chromium.org Review-Url: https://codereview.chromium.org/2647273002 Cr-Commit-Position: refs/heads/master@{#446602} Committed: https://chromium.googlesource.com/chromium/src/+/79db18ef48f6b3a9da4ca6be99beb7697d342a7c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -44 lines) Patch
M chrome/app/chrome_main_delegate.h View 3 chunks +3 lines, -5 lines 0 comments Download
M chrome/app/chrome_main_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/nacl/zygote/nacl_fork_delegate_linux.h View 2 chunks +2 lines, -4 lines 0 comments Download
M components/nacl/zygote/nacl_fork_delegate_linux.cc View 3 chunks +6 lines, -5 lines 0 comments Download
M content/app/content_main_runner.cc View 2 chunks +2 lines, -1 line 0 comments Download
M content/public/app/content_main_delegate.h View 2 chunks +4 lines, -4 lines 0 comments Download
M content/public/app/content_main_delegate.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/zygote/zygote_linux.h View 3 chunks +4 lines, -3 lines 0 comments Download
M content/zygote/zygote_linux.cc View 2 chunks +3 lines, -5 lines 0 comments Download
M content/zygote/zygote_main.h View 1 chunk +5 lines, -4 lines 0 comments Download
M content/zygote/zygote_main_linux.cc View 3 chunks +4 lines, -6 lines 0 comments Download
M extensions/shell/app/shell_main_delegate.h View 2 chunks +3 lines, -3 lines 0 comments Download
M extensions/shell/app/shell_main_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 22 (13 generated)
leonhsl(Using Gerrit)
avi@chromium.org: Please review changes in content/ bradnelson@chromium.org: Please review changes in components/nacl/ rockot@chromium.org: Please review ...
3 years, 11 months ago (2017-01-23 05:57:19 UTC) #7
Ken Rockot(use gerrit already)
lgtm
3 years, 11 months ago (2017-01-23 20:53:53 UTC) #10
leonhsl(Using Gerrit)
+kinuko@ Hi, would you PTAL for content/ OWNER review? Thanks. Move avi@ to CC because ...
3 years, 11 months ago (2017-01-25 02:01:02 UTC) #12
kinuko
lgtm
3 years, 11 months ago (2017-01-25 02:23:53 UTC) #13
leonhsl(Using Gerrit)
Friendly ping bradnelson@ and sky@, Thanks.
3 years, 11 months ago (2017-01-25 10:40:53 UTC) #14
sky
LGTM
3 years, 11 months ago (2017-01-25 16:28:58 UTC) #15
leonhsl(Using Gerrit)
As components/nacl/zygote/nacl_fork_delegate_linux.{cc,h} just have some trivial changes, so let me TBR bradnelson@ and send this ...
3 years, 11 months ago (2017-01-27 04:32:14 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2647273002/20001
3 years, 11 months ago (2017-01-27 04:33:01 UTC) #19
commit-bot: I haz the power
3 years, 11 months ago (2017-01-27 05:27:29 UTC) #22
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/79db18ef48f6b3a9da4ca6be99be...

Powered by Google App Engine
This is Rietveld 408576698