Make vulcanize.md more generic and remove specifics about node modules

Make vulcanize.md more generic and remove specifics about node modules

Now that node.js is included in Chromium, installing local tools is not
required.

R=dpapad@chromium.org
BUG=673825
NOTRY=true

Review-Url: https://codereview.chromium.org/2647203002
Cr-Commit-Position: refs/heads/master@{#445594}
Committed: https://chromium.googlesource.com/chromium/src/+/f02a25aa9ec8c515ba1a207a4ecf32dc2ab8c57f

[dpapad, 2017-01-23 19:20:54]

LGTM with nits.

https://codereview.chromium.org/2647203002/diff/1/docs/optimizing_web_uis.md
File docs/optimizing_web_uis.md (right):

https://codereview.chromium.org/2647203002/diff/1/docs/optimizing_web_uis.md#...
docs/optimizing_web_uis.md:22: *NOTE: This is likely to change soon to be more
tightly integrated with GN /
Perhaps add a link to
https://bugs.chromium.org/p/chromium/issues/detail?id=673825 here?

https://codereview.chromium.org/2647203002/diff/1/docs/optimizing_web_uis.md#...
docs/optimizing_web_uis.md:42:
[vulcanize](https://github.com/Polymer/vulcanize).  It processes a page starting
This URL just redirects to polymer-bundler repo. Perhaps link to
https://github.com/Polymer/polymer-bundler/tree/1.x directly?

[Dan Beam, 2017-01-24 01:50:24]

https://codereview.chromium.org/2647203002/diff/1/docs/optimizing_web_uis.md
File docs/optimizing_web_uis.md (right):

https://codereview.chromium.org/2647203002/diff/1/docs/optimizing_web_uis.md#...
docs/optimizing_web_uis.md:22: *NOTE: This is likely to change soon to be more
tightly integrated with GN /
On 2017/01/23 19:20:53, dpapad wrote:
> Perhaps add a link to
> https://bugs.chromium.org/p/chromium/issues/detail?id=673825 here?

Done.

https://codereview.chromium.org/2647203002/diff/1/docs/optimizing_web_uis.md#...
docs/optimizing_web_uis.md:42:
[vulcanize](https://github.com/Polymer/vulcanize).  It processes a page starting
On 2017/01/23 19:20:53, dpapad wrote:
> This URL just redirects to polymer-bundler repo. Perhaps link to
> https://github.com/Polymer/polymer-bundler/tree/1.x directly?

Done.

[Dan Beam, 2017-01-24 01:50:40]

Description was changed from

==========
Make vulcanize.md more generic and remove specifics about node modules

Now that node.js is included in Chromium, installing local tools is not
required.

R=dpapad@chromium.org
BUG=
==========

to

==========
Make vulcanize.md more generic and remove specifics about node modules

Now that node.js is included in Chromium, installing local tools is not
required.

R=dpapad@chromium.org
BUG=673825
NOTRY=true
==========

[Dan Beam, 2017-01-24 01:50:42]

The CQ bit was checked by dbeam@chromium.org

[Dan Beam, 2017-01-24 01:50:43]

The patchset sent to the CQ was uploaded after l-g-t-m from dpapad@chromium.org
Link to the patchset: https://codereview.chromium.org/2647203002/#ps20001
(title: "dpapad@ review")

[dpapad, 2017-01-24 01:51:23]

lgtm

[commit-bot: I haz the power, 2017-01-24 01:51:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-24 01:58:41]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1485222642961880,
"parent_rev": "6a2436acde75b81198036ed4d27fb1a98d72ddbd", "commit_rev":
"f02a25aa9ec8c515ba1a207a4ecf32dc2ab8c57f"}

[commit-bot: I haz the power, 2017-01-24 01:59:12]

Description was changed from

==========
Make vulcanize.md more generic and remove specifics about node modules

Now that node.js is included in Chromium, installing local tools is not
required.

R=dpapad@chromium.org
BUG=673825
NOTRY=true
==========

to

==========
Make vulcanize.md more generic and remove specifics about node modules

Now that node.js is included in Chromium, installing local tools is not
required.

R=dpapad@chromium.org
BUG=673825
NOTRY=true

Review-Url: https://codereview.chromium.org/2647203002
Cr-Commit-Position: refs/heads/master@{#445594}
Committed:
https://chromium.googlesource.com/chromium/src/+/f02a25aa9ec8c515ba1a207a4ecf...
==========

[commit-bot: I haz the power, 2017-01-24 01:59:13]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/f02a25aa9ec8c515ba1a207a4ecf...