Chromium Code Reviews Chromium Code Reviews
Issue
264713015:
iPhone 5c marketing site repaints incorrectly with layer squashing (Closed)
DescriptioniPhone 5c marketing site repaints incorrectly with layer squashing
In the PaintsIntoGroupedBacking branch of
RenderLayerRepainter::setBackingNeedsRepaintInRect, we can
mistakenly use LayoutState if the transformedAncestor of the
RenderLayer is actually the RenderView. Unforunately,
LayoutState is not yet smart enough to handle repaints into
compositing containers, which means we'll compute the wrong
repaint rect for the squashed layer.
This CL adds a LayoutStateDisabler to this code path so that
we'll explicitly not use LayoutState. In the future, if we
make LayoutState smart enough to handle composited repaints,
we'll need to remove this disabler.
BUG=369478
R=leviw@chromium.org
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=173333
Patch Set 1 #Patch Set 2 : Repaint test with bogus results #Patch Set 3 : Impoved test, results still for failing case #Patch Set 4 : Now with fix #
Total comments: 4
Patch Set 5 : Moar const #
Messages
Total messages: 9 (0 generated)
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
