[Sync] Convert Autocomplete to use sync's report error function.

[Sync] Convert Autocomplete to use sync's report error function.

Instead of uploading all errors that are encountered, which is desirable
for initial dev/canary rollout, we should switch Autocomplete to use our
error function (that filters to 1% of reports on dev/canary only) at
some point before beta (possibly before 100% of dev/canary).

This is a reference CL for when that happens.

BUG=683332

[maxbogue, 2017-01-20 20:38:48]

The CQ bit was checked by maxbogue@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-20 20:39:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-20 20:49:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-20 20:49:11]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[maxbogue, 2017-01-20 20:57:03]

The CQ bit was checked by maxbogue@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-20 20:57:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-20 21:06:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-20 21:06:17]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)

[maxbogue, 2017-01-20 21:27:53]

The CQ bit was checked by maxbogue@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-20 21:28:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-20 21:38:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-20 21:38:11]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[maxbogue, 2017-01-20 21:41:57]

The CQ bit was checked by maxbogue@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-20 21:42:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-20 22:40:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-20 22:40:18]

Dry run: This issue passed the CQ dry run.

[skym, 2017-01-24 20:49:42]

skym@chromium.org changed reviewers:
+ skym@chromium.org

[skym, 2017-01-24 20:49:43]

lgtm

https://codereview.chromium.org/2647113002/diff/60001/components/autofill/cor...
File components/autofill/core/browser/webdata/autocomplete_sync_bridge.cc
(right):

https://codereview.chromium.org/2647113002/diff/60001/components/autofill/cor...
components/autofill/core/browser/webdata/autocomplete_sync_bridge.cc:283:
base::BindRepeating(&ReportUnrecoverableError, channel))));
Can you create two functions in
components/sync/base/report_unrecoverable_error.h, one that reports at 100%, and
one that invokes the other 1% of the time, and then land this CL now?

[maxbogue, 2017-02-02 22:14:46]

On 2017/01/24 20:49:43, skym wrote:
> lgtm
> 
>
https://codereview.chromium.org/2647113002/diff/60001/components/autofill/cor...
> File components/autofill/core/browser/webdata/autocomplete_sync_bridge.cc
> (right):
> 
>
https://codereview.chromium.org/2647113002/diff/60001/components/autofill/cor...
> components/autofill/core/browser/webdata/autocomplete_sync_bridge.cc:283:
> base::BindRepeating(&ReportUnrecoverableError, channel))));
> Can you create two functions in
> components/sync/base/report_unrecoverable_error.h, one that reports at 100%,
and
> one that invokes the other 1% of the time, and then land this CL now?

I don't have time to do this since I'm trying to write some more documentation
before leaving. You can though!