components/autofill/core/browser/webdata/autocomplete_sync_bridge.cc - Issue 2647113002: [Sync] Convert Autocomplete to use sync's report error function.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/browser/webdata/autocomplete_sync_bridge.cc

Issue 2647113002: [Sync] Convert Autocomplete to use sync's report error function. (Closed)

Patch Set: Wrong dep... Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/autofill/core/browser/webdata/autocomplete_sync_bridge.cc

diff --git a/components/autofill/core/browser/webdata/autocomplete_sync_bridge.cc b/components/autofill/core/browser/webdata/autocomplete_sync_bridge.cc

index 0bf47d314ba2ab9ea4a087443d69be3858b8fc3f..6d870067640fcd834de939917b9ec9457fe93851 100644

--- a/components/autofill/core/browser/webdata/autocomplete_sync_bridge.cc

+++ b/components/autofill/core/browser/webdata/autocomplete_sync_bridge.cc

@@ -11,7 +11,6 @@

#include <vector>

#include "base/bind.h"

-#include "base/debug/dump_without_crashing.h"

#include "base/memory/ptr_util.h"

#include "base/strings/utf_string_conversions.h"

#include "components/autofill/core/browser/proto/autofill_sync.pb.h"

@@ -19,6 +18,7 @@

#include "components/autofill/core/browser/webdata/autofill_table.h"

#include "components/autofill/core/browser/webdata/autofill_webdata_backend.h"

#include "components/autofill/core/browser/webdata/autofill_webdata_service.h"

+#include "components/sync/base/report_unrecoverable_error.h"

#include "components/sync/model/entity_data.h"

#include "components/sync/model/model_type_change_processor.h"

#include "components/sync/model/mutable_data_batch.h"

@@ -26,7 +26,6 @@

using base::Optional;

using base::Time;

-using base::debug::DumpWithoutCrashing;

using sync_pb::AutofillSpecifics;

using syncer::EntityChange;

using syncer::EntityChangeList;

@@ -36,6 +35,7 @@ using syncer::MetadataChangeList;

using syncer::ModelError;

using syncer::ModelTypeChangeProcessor;

using syncer::MutableDataBatch;

+using syncer::ReportUnrecoverableError;

namespace autofill {

@@ -272,14 +272,15 @@ class SyncDifferenceTracker {

// static

void AutocompleteSyncBridge::CreateForWebDataServiceAndBackend(

AutofillWebDataService* web_data_service,

- AutofillWebDataBackend* web_data_backend) {

+ AutofillWebDataBackend* web_data_backend,

+ version_info::Channel channel) {

web_data_service->GetDBUserData()->SetUserData(

UserDataKey(),

new AutocompleteSyncBridge(

web_data_backend,

base::BindRepeating(

&ModelTypeChangeProcessor::Create,

- base::BindRepeating(base::IgnoreResult(&DumpWithoutCrashing)))));

+ base::BindRepeating(&ReportUnrecoverableError, channel))));

skym 2017/01/24 20:49:43 Can you create two functions in components/sync/ba

}

// static

« no previous file with comments | « components/autofill/core/browser/webdata/autocomplete_sync_bridge.h ('k') | components/webdata_services/BUILD.gn » ('j') | no next file with comments »