Add initial VR interactive omnibox.

Add initial VR interactive omnibox.

- It depends on the HTML-based virtual keyboard.
- It can accept URL text entry and trigger navigation.
- It offers suggestions based on text entered.
- It allows navigation from suggestions.
- It is NOT styled well.
- It is NOT yet enabled in any mode.
- It is NOT yet complete in any way.

BUG=641508
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2647053002
Cr-Commit-Position: refs/heads/master@{#447086}
Committed: https://chromium.googlesource.com/chromium/src/+/f0ef9a78b5c8879e904ea51c02fbb3e7a36af600

[cjgrant, 2017-01-20 17:17:49]

Description was changed from

==========
Add initial VR interactive omnibox.

- It depends on the HTML-based virtual keyboard.
- It can accept URL text entry and trigger navigation.
- It offers suggestions based on text entered.
- It allows navigation from suggestions.
- It is NOT styled well.
- It is NOT yet enabled in any mode.
- It is NOT yet complete in any way.

BUG=641508
==========

to

==========
Add initial VR interactive omnibox.

- It depends on the HTML-based virtual keyboard.
- It can accept URL text entry and trigger navigation.
- It offers suggestions based on text entered.
- It allows navigation from suggestions.
- It is NOT styled well.
- It is NOT yet enabled in any mode.
- It is NOT yet complete in any way.

BUG=641508
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[cjgrant, 2017-01-20 17:22:27]

cjgrant@chromium.org changed reviewers:
+ asimjour@chromium.org, bshe@chromium.org, mthiesse@chromium.org

[cjgrant, 2017-01-20 17:25:21]

https://codereview.chromium.org/2647053002/diff/1/chrome/browser/resources/vr...
File chrome/browser/resources/vr_shell/vr_shell_ui.js (left):

https://codereview.chromium.org/2647053002/diff/1/chrome/browser/resources/vr...
chrome/browser/resources/vr_shell/vr_shell_ui.js:177: this.reloadUiButton = new
DomUiElement('#reload-ui-button');
The reloadUiButton rework in this module is just decoupling it from the actual
controls.  It was originally coupled only for easy positioning.

[mthiesse, 2017-01-20 18:48:35]

https://codereview.chromium.org/2647053002/diff/1/chrome/browser/android/vr_s...
File chrome/browser/android/vr_shell/vr_omnibox.cc (right):

https://codereview.chromium.org/2647053002/diff/1/chrome/browser/android/vr_s...
chrome/browser/android/vr_shell/vr_omnibox.cc:18: autocomplete_controller_(new
AutocompleteController(
s/new AutocompleteController(/base::MakeUnique<AutocompleteController>(/

https://codereview.chromium.org/2647053002/diff/1/chrome/browser/android/vr_s...
chrome/browser/android/vr_shell/vr_omnibox.cc:42: input_ = AutocompleteInput(
Don't think copying is necessary here, even though it's allowed for this class.
Why not use a unique_ptr and reset it?

https://codereview.chromium.org/2647053002/diff/1/chrome/browser/android/vr_s...
chrome/browser/android/vr_shell/vr_omnibox.cc:52:
std::unique_ptr<base::ListValue> suggestions(new base::ListValue);
Prefer base::MakeUnique here and below.

( std::unique_ptr<base::ListValue> suggestions =
base::MakeUnique<base::ListValue>(); )

https://codereview.chromium.org/2647053002/diff/1/chrome/browser/android/vr_s...
File chrome/browser/android/vr_shell/vr_omnibox.h (right):

https://codereview.chromium.org/2647053002/diff/1/chrome/browser/android/vr_s...
chrome/browser/android/vr_shell/vr_omnibox.h:9: #include
"base/strings/string16.h"
Looks like a lot of these includes don't need to be in the header.

[bshe, 2017-01-23 16:24:37]

https://codereview.chromium.org/2647053002/diff/1/chrome/browser/android/vr_s...
File chrome/browser/android/vr_shell/vr_omnibox.cc (right):

https://codereview.chromium.org/2647053002/diff/1/chrome/browser/android/vr_s...
chrome/browser/android/vr_shell/vr_omnibox.cc:1: // Copyright 2016 The Chromium
Authors. All rights reserved.
nit: 2017

https://codereview.chromium.org/2647053002/diff/1/chrome/browser/android/vr_s...
chrome/browser/android/vr_shell/vr_omnibox.cc:11: #include
"components/omnibox/browser/autocomplete_input.h"
I am not familiar with the classes that are used here. Perhaps it is a good idea
to ask review from one of the owners of these files to review this class too?

https://codereview.chromium.org/2647053002/diff/1/chrome/browser/android/vr_s...
chrome/browser/android/vr_shell/vr_omnibox.cc:24: VrOmnibox::~VrOmnibox() {}
use "= default"?

https://codereview.chromium.org/2647053002/diff/1/chrome/browser/android/vr_s...
File chrome/browser/android/vr_shell/vr_omnibox.h (right):

https://codereview.chromium.org/2647053002/diff/1/chrome/browser/android/vr_s...
chrome/browser/android/vr_shell/vr_omnibox.h:37: std::unique_ptr<Profile>
profile_;
do you need to own profile here? It looks like profile is a global obj.

https://codereview.chromium.org/2647053002/diff/1/chrome/browser/android/vr_s...
File chrome/browser/android/vr_shell/vr_shell.cc (right):

https://codereview.chromium.org/2647053002/diff/1/chrome/browser/android/vr_s...
chrome/browser/android/vr_shell/vr_shell.cc:405: // transition type down from
the UI.
nit: perhaps create a crbug to track this

https://codereview.chromium.org/2647053002/diff/1/chrome/browser/resources/vr...
File chrome/browser/resources/vr_shell/vr_shell_ui.css (right):

https://codereview.chromium.org/2647053002/diff/1/chrome/browser/resources/vr...
chrome/browser/resources/vr_shell/vr_shell_ui.css:210: font-family: arial;
is this necessary? wouldn't it inherit from #omnibox-ui-element

https://codereview.chromium.org/2647053002/diff/1/chrome/browser/resources/vr...
File chrome/browser/resources/vr_shell/vr_shell_ui.html (right):

https://codereview.chromium.org/2647053002/diff/1/chrome/browser/resources/vr...
chrome/browser/resources/vr_shell/vr_shell_ui.html:61: <input
id="omnibox-input-field"></input>
can this be type="url"?

https://codereview.chromium.org/2647053002/diff/1/chrome/browser/resources/vr...
File chrome/browser/resources/vr_shell/vr_shell_ui.js (right):

https://codereview.chromium.org/2647053002/diff/1/chrome/browser/resources/vr...
chrome/browser/resources/vr_shell/vr_shell_ui.js:217:
ui.updateElement(this.uiElement.uiElementId, update);
nit: move line 215 to 217 out as a reusable function?

https://codereview.chromium.org/2647053002/diff/1/chrome/browser/resources/vr...
chrome/browser/resources/vr_shell/vr_shell_ui.js:496: api.Action.LOAD_URL,
{'url': 'http://' + e.target.value});
does this mean we always try http request first? Is this the same as normal
omnibox?

https://codereview.chromium.org/2647053002/diff/1/chrome/browser/resources/vr...
chrome/browser/resources/vr_shell/vr_shell_ui.js:506: for (var i = 0; i < 5;
i++) {
avoid use magic number 5

https://codereview.chromium.org/2647053002/diff/1/chrome/browser/resources/vr...
chrome/browser/resources/vr_shell/vr_shell_ui.js:510: console.log('Going to URL:
' + url);
nit: remove log in production code

https://codereview.chromium.org/2647053002/diff/1/chrome/browser/resources/vr...
chrome/browser/resources/vr_shell/vr_shell_ui.js:525: let omnibox =
this.domUiElement.domElement;
omnibox is not used?

https://codereview.chromium.org/2647053002/diff/1/chrome/browser/resources/vr...
chrome/browser/resources/vr_shell/vr_shell_ui.js:534: element.innerHTML = '';
nit: use textContent instead of innerHTML

[asimjour1, 2017-01-23 18:25:59]

https://codereview.chromium.org/2647053002/diff/1/chrome/browser/android/vr_s...
File chrome/browser/android/vr_shell/vr_shell.cc (right):

https://codereview.chromium.org/2647053002/diff/1/chrome/browser/android/vr_s...
chrome/browser/android/vr_shell/vr_shell.cc:411: case OMNIBOX_CONTENT:
nit: OMNIBOX_CONTENT doesn't sound like an action. perhaps renaming it.

[cjgrant, 2017-01-24 15:31:40]

https://codereview.chromium.org/2647053002/diff/1/chrome/browser/android/vr_s...
File chrome/browser/android/vr_shell/vr_omnibox.cc (right):

https://codereview.chromium.org/2647053002/diff/1/chrome/browser/android/vr_s...
chrome/browser/android/vr_shell/vr_omnibox.cc:1: // Copyright 2016 The Chromium
Authors. All rights reserved.
On 2017/01/23 16:24:36, bshe wrote:
> nit: 2017

Done.

https://codereview.chromium.org/2647053002/diff/1/chrome/browser/android/vr_s...
chrome/browser/android/vr_shell/vr_omnibox.cc:11: #include
"components/omnibox/browser/autocomplete_input.h"
On 2017/01/23 16:24:36, bshe wrote:
> I am not familiar with the classes that are used here. Perhaps it is a good
idea
> to ask review from one of the owners of these files to review this class too?

Yes, I agree.  Lets finish the first pass, then I'll loop in some Omnibox
Experts (tm).

https://codereview.chromium.org/2647053002/diff/1/chrome/browser/android/vr_s...
chrome/browser/android/vr_shell/vr_omnibox.cc:18: autocomplete_controller_(new
AutocompleteController(
On 2017/01/20 18:48:35, mthiesse wrote:
> s/new AutocompleteController(/base::MakeUnique<AutocompleteController>(/

Done.  Cool, I didn't know the intent of MakeUnique until now.

https://codereview.chromium.org/2647053002/diff/1/chrome/browser/android/vr_s...
chrome/browser/android/vr_shell/vr_omnibox.cc:24: VrOmnibox::~VrOmnibox() {}
On 2017/01/23 16:24:37, bshe wrote:
> use "= default"?

Done.  Funny that it's more characters than the alternative. :)

https://codereview.chromium.org/2647053002/diff/1/chrome/browser/android/vr_s...
chrome/browser/android/vr_shell/vr_omnibox.cc:42: input_ = AutocompleteInput(
On 2017/01/20 18:48:35, mthiesse wrote:
> Don't think copying is necessary here, even though it's allowed for this
class.
> Why not use a unique_ptr and reset it?

This was a direct ripoff of Clank's approach.

https://cs.chromium.org/chromium/src/chrome/browser/android/omnibox/autocompl...

That said, I don't know if either makes sense.  The Start() call reads and
copies the incoming structure, meaning input ought to be scoped to this
function.  When omnibox owners review this change, I'll raise this question.

https://codereview.chromium.org/2647053002/diff/1/chrome/browser/android/vr_s...
chrome/browser/android/vr_shell/vr_omnibox.cc:52:
std::unique_ptr<base::ListValue> suggestions(new base::ListValue);
On 2017/01/20 18:48:35, mthiesse wrote:
> Prefer base::MakeUnique here and below.
> 
> ( std::unique_ptr<base::ListValue> suggestions =
> base::MakeUnique<base::ListValue>(); )

Done, except I'm using auto.  Other Chrome code does this, and I think it's a
perfect use of auto.  The type is explicit very visible.

https://codereview.chromium.org/2647053002/diff/1/chrome/browser/android/vr_s...
File chrome/browser/android/vr_shell/vr_shell.cc (right):

https://codereview.chromium.org/2647053002/diff/1/chrome/browser/android/vr_s...
chrome/browser/android/vr_shell/vr_shell.cc:405: // transition type down from
the UI.
On 2017/01/23 16:24:37, bshe wrote:
> nit: perhaps create a crbug to track this

Done.

https://codereview.chromium.org/2647053002/diff/1/chrome/browser/android/vr_s...
chrome/browser/android/vr_shell/vr_shell.cc:411: case OMNIBOX_CONTENT:
On 2017/01/23 18:25:59, asimjour1 wrote:
> nit: OMNIBOX_CONTENT doesn't sound like an action. perhaps renaming it.

I agree, but I'm not sure of the best way to address this.  We have a mix of two
approaches:  A set of WebUI callbacks (domLoaded, updateScene, doAction,
setUiCssSize), and a set of actions.  All of these make calls to VrShell.  The
callbacks make specific VrShell function calls, whereas the actions pass a
command type and arguments to VrShell to parse.

In a perfect world, nothing but the message handler would parse arguments, so as
to keep the dictionary structure private to the JS-native interface.  But if we
do this, we just need to create classes to take that data and pump it through to
VrShell, UI, etc.  Lets chat about this one in person.

https://codereview.chromium.org/2647053002/diff/1/chrome/browser/resources/vr...
File chrome/browser/resources/vr_shell/vr_shell_ui.js (right):

https://codereview.chromium.org/2647053002/diff/1/chrome/browser/resources/vr...
chrome/browser/resources/vr_shell/vr_shell_ui.js:217:
ui.updateElement(this.uiElement.uiElementId, update);
On 2017/01/23 16:24:37, bshe wrote:
> nit: move line 215 to 217 out as a reusable function?

Done.

https://codereview.chromium.org/2647053002/diff/1/chrome/browser/resources/vr...
chrome/browser/resources/vr_shell/vr_shell_ui.js:496: api.Action.LOAD_URL,
{'url': 'http://' + e.target.value});
On 2017/01/23 16:24:37, bshe wrote:
> does this mean we always try http request first? Is this the same as normal
> omnibox?

This will have to be improved - this is only a first cut.

https://codereview.chromium.org/2647053002/diff/1/chrome/browser/resources/vr...
chrome/browser/resources/vr_shell/vr_shell_ui.js:506: for (var i = 0; i < 5;
i++) {
On 2017/01/23 16:24:37, bshe wrote:
> avoid use magic number 5

Done.  I now count the number of available suggestion slots.

https://codereview.chromium.org/2647053002/diff/1/chrome/browser/resources/vr...
chrome/browser/resources/vr_shell/vr_shell_ui.js:510: console.log('Going to URL:
' + url);
On 2017/01/23 16:24:37, bshe wrote:
> nit: remove log in production code

Done.

https://codereview.chromium.org/2647053002/diff/1/chrome/browser/resources/vr...
chrome/browser/resources/vr_shell/vr_shell_ui.js:525: let omnibox =
this.domUiElement.domElement;
On 2017/01/23 16:24:37, bshe wrote:
> omnibox is not used?

Done.

https://codereview.chromium.org/2647053002/diff/1/chrome/browser/resources/vr...
chrome/browser/resources/vr_shell/vr_shell_ui.js:534: element.innerHTML = '';
On 2017/01/23 16:24:37, bshe wrote:
> nit: use textContent instead of innerHTML

Done.

[cjgrant, 2017-01-24 17:11:32]

Description was changed from

==========
Add initial VR interactive omnibox.

- It depends on the HTML-based virtual keyboard.
- It can accept URL text entry and trigger navigation.
- It offers suggestions based on text entered.
- It allows navigation from suggestions.
- It is NOT styled well.
- It is NOT yet enabled in any mode.
- It is NOT yet complete in any way.

BUG=641508
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Add initial VR interactive omnibox.

- It depends on the HTML-based virtual keyboard.
- It can accept URL text entry and trigger navigation.
- It offers suggestions based on text entered.
- It allows navigation from suggestions.
- It is NOT styled well.
- It is NOT yet enabled in any mode.
- It is NOT yet complete in any way.

BUG=641508
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[cjgrant, 2017-01-24 17:11:32]

cjgrant@chromium.org changed reviewers:
+ pkasting@chromium.org

[cjgrant, 2017-01-24 18:46:13]

https://codereview.chromium.org/2647053002/diff/1/chrome/browser/android/vr_s...
File chrome/browser/android/vr_shell/vr_omnibox.h (right):

https://codereview.chromium.org/2647053002/diff/1/chrome/browser/android/vr_s...
chrome/browser/android/vr_shell/vr_omnibox.h:9: #include
"base/strings/string16.h"
On 2017/01/20 18:48:35, mthiesse wrote:
> Looks like a lot of these includes don't need to be in the header.

Scrubbed here and elsewhere (referred to lint output).

https://codereview.chromium.org/2647053002/diff/1/chrome/browser/android/vr_s...
chrome/browser/android/vr_shell/vr_omnibox.h:37: std::unique_ptr<Profile>
profile_;
On 2017/01/23 16:24:37, bshe wrote:
> do you need to own profile here? It looks like profile is a global obj.

The profile handling looks a bit more interesting.  I use a function that Clank
uses in some cases, but this function is marked "avoid using at all cost".  I
think I need to rework this.

[cjgrant, 2017-01-24 20:13:55]

https://codereview.chromium.org/2647053002/diff/60001/chrome/browser/android/...
File chrome/browser/android/vr_shell/vr_shell.cc (right):

https://codereview.chromium.org/2647053002/diff/60001/chrome/browser/android/...
chrome/browser/android/vr_shell/vr_shell.cc:6: j
Hah, yes, nothing to see here.

[mthiesse, 2017-01-24 21:42:14]

lgtm

https://codereview.chromium.org/2647053002/diff/60001/chrome/browser/android/...
File chrome/browser/android/vr_shell/ui_interface.cc (right):

https://codereview.chromium.org/2647053002/diff/60001/chrome/browser/android/...
chrome/browser/android/vr_shell/ui_interface.cc:20: omnibox_.reset(new
VrOmnibox(this));
nit: omnibox_ = base::MakeUnique<VrOmnibox>(this);

[mthiesse, 2017-01-24 21:42:46]

On 2017/01/24 21:42:14, mthiesse wrote:
> lgtm
> 
>
https://codereview.chromium.org/2647053002/diff/60001/chrome/browser/android/...
> File chrome/browser/android/vr_shell/ui_interface.cc (right):
> 
>
https://codereview.chromium.org/2647053002/diff/60001/chrome/browser/android/...
> chrome/browser/android/vr_shell/ui_interface.cc:20: omnibox_.reset(new
> VrOmnibox(this));
> nit: omnibox_ = base::MakeUnique<VrOmnibox>(this);

You should probably wait on biao though to sign off on the css/js stuff.

[bshe, 2017-01-26 15:30:58]

https://codereview.chromium.org/2647053002/diff/100001/chrome/browser/resourc...
File chrome/browser/resources/vr_shell/vr_shell_ui.js (right):

https://codereview.chromium.org/2647053002/diff/100001/chrome/browser/resourc...
chrome/browser/resources/vr_shell/vr_shell_ui.js:518: for (var i = 0; i <
this.maxSuggestions; i++) {
you can probably use querySelectorAll and iterate on the element list it
returns.

https://codereview.chromium.org/2647053002/diff/100001/chrome/browser/resourc...
chrome/browser/resources/vr_shell/vr_shell_ui.js:541: for (var i = 0; i < 5;
i++) {
avoid use 5.

https://codereview.chromium.org/2647053002/diff/100001/chrome/browser/resourc...
chrome/browser/resources/vr_shell/vr_shell_ui.js:549: this.suggestionUrls[i] =
suggestions[i].url;
perhaps you could just use element.url = suggestions[i].url to avoid depend on
index?

[cjgrant, 2017-01-26 17:31:11]

https://codereview.chromium.org/2647053002/diff/60001/chrome/browser/android/...
File chrome/browser/android/vr_shell/ui_interface.cc (right):

https://codereview.chromium.org/2647053002/diff/60001/chrome/browser/android/...
chrome/browser/android/vr_shell/ui_interface.cc:20: omnibox_.reset(new
VrOmnibox(this));
On 2017/01/24 21:42:14, mthiesse wrote:
> nit: omnibox_ = base::MakeUnique<VrOmnibox>(this);

Done.

https://codereview.chromium.org/2647053002/diff/100001/chrome/browser/resourc...
File chrome/browser/resources/vr_shell/vr_shell_ui.js (right):

https://codereview.chromium.org/2647053002/diff/100001/chrome/browser/resourc...
chrome/browser/resources/vr_shell/vr_shell_ui.js:518: for (var i = 0; i <
this.maxSuggestions; i++) {
On 2017/01/26 15:30:58, bshe wrote:
> you can probably use querySelectorAll and iterate on the element list it
> returns.

Done.

https://codereview.chromium.org/2647053002/diff/100001/chrome/browser/resourc...
chrome/browser/resources/vr_shell/vr_shell_ui.js:541: for (var i = 0; i < 5;
i++) {
On 2017/01/26 15:30:58, bshe wrote:
> avoid use 5.

Done.  Whoops, sorry I missed this.

https://codereview.chromium.org/2647053002/diff/100001/chrome/browser/resourc...
chrome/browser/resources/vr_shell/vr_shell_ui.js:549: this.suggestionUrls[i] =
suggestions[i].url;
On 2017/01/26 15:30:58, bshe wrote:
> perhaps you could just use element.url = suggestions[i].url to avoid depend on
> index?

Done.  Good call, this is much better.

[bshe, 2017-01-26 17:45:36]

On 2017/01/26 17:31:11, cjgrant wrote:
>
https://codereview.chromium.org/2647053002/diff/60001/chrome/browser/android/...
> File chrome/browser/android/vr_shell/ui_interface.cc (right):
> 
>
https://codereview.chromium.org/2647053002/diff/60001/chrome/browser/android/...
> chrome/browser/android/vr_shell/ui_interface.cc:20: omnibox_.reset(new
> VrOmnibox(this));
> On 2017/01/24 21:42:14, mthiesse wrote:
> > nit: omnibox_ = base::MakeUnique<VrOmnibox>(this);
> 
> Done.
> 
>
https://codereview.chromium.org/2647053002/diff/100001/chrome/browser/resourc...
> File chrome/browser/resources/vr_shell/vr_shell_ui.js (right):
> 
>
https://codereview.chromium.org/2647053002/diff/100001/chrome/browser/resourc...
> chrome/browser/resources/vr_shell/vr_shell_ui.js:518: for (var i = 0; i <
> this.maxSuggestions; i++) {
> On 2017/01/26 15:30:58, bshe wrote:
> > you can probably use querySelectorAll and iterate on the element list it
> > returns.
> 
> Done.
> 
>
https://codereview.chromium.org/2647053002/diff/100001/chrome/browser/resourc...
> chrome/browser/resources/vr_shell/vr_shell_ui.js:541: for (var i = 0; i < 5;
> i++) {
> On 2017/01/26 15:30:58, bshe wrote:
> > avoid use 5.
> 
> Done.  Whoops, sorry I missed this.
> 
>
https://codereview.chromium.org/2647053002/diff/100001/chrome/browser/resourc...
> chrome/browser/resources/vr_shell/vr_shell_ui.js:549: this.suggestionUrls[i] =
> suggestions[i].url;
> On 2017/01/26 15:30:58, bshe wrote:
> > perhaps you could just use element.url = suggestions[i].url to avoid depend
on
> > index?
> 
> Done.  Good call, this is much better.

lgtm

[cjgrant, 2017-01-30 20:28:51]

The CQ bit was checked by cjgrant@chromium.org

[cjgrant, 2017-01-30 20:28:51]

The patchset sent to the CQ was uploaded after l-g-t-m from
mthiesse@chromium.org, bshe@chromium.org
Link to the patchset: https://codereview.chromium.org/2647053002/#ps160001
(title: "Rebase to ToT.")

[commit-bot: I haz the power, 2017-01-30 20:29:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-30 22:09:08]

CQ is committing da patch.

Bot data: {"patchset_id": 160001, "attempt_start_ts": 1485808131438300,
"parent_rev": "14e09ca425d1ee9572f69d29cdd00cff1a1b2bfc", "commit_rev":
"f0ef9a78b5c8879e904ea51c02fbb3e7a36af600"}

[commit-bot: I haz the power, 2017-01-30 22:09:50]

Description was changed from

==========
Add initial VR interactive omnibox.

- It depends on the HTML-based virtual keyboard.
- It can accept URL text entry and trigger navigation.
- It offers suggestions based on text entered.
- It allows navigation from suggestions.
- It is NOT styled well.
- It is NOT yet enabled in any mode.
- It is NOT yet complete in any way.

BUG=641508
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Add initial VR interactive omnibox.

- It depends on the HTML-based virtual keyboard.
- It can accept URL text entry and trigger navigation.
- It offers suggestions based on text entered.
- It allows navigation from suggestions.
- It is NOT styled well.
- It is NOT yet enabled in any mode.
- It is NOT yet complete in any way.

BUG=641508
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2647053002
Cr-Commit-Position: refs/heads/master@{#447086}
Committed:
https://chromium.googlesource.com/chromium/src/+/f0ef9a78b5c8879e904ea51c02fb...
==========

[commit-bot: I haz the power, 2017-01-30 22:09:51]

Committed patchset #9 (id:160001) as
https://chromium.googlesource.com/chromium/src/+/f0ef9a78b5c8879e904ea51c02fb...