Fix hints reported by analyzer.

pkg/compiler/lib/src/compile_time_constants.dart

Index: pkg/compiler/lib/src/compile_time_constants.dart
diff --git a/pkg/compiler/lib/src/compile_time_constants.dart b/pkg/compiler/lib/src/compile_time_constants.dart
index 82459f35510892723bc5fc52b7e57a535f2756b7..7151e2eb99b0a440b381358f507279b3f2a0973d 100644
--- a/pkg/compiler/lib/src/compile_time_constants.dart
+++ b/pkg/compiler/lib/src/compile_time_constants.dart
@@ -1294,7 +1294,7 @@ class ConstructorEvaluator extends CompileTimeConstantEvaluator {
       Function compileArgument = (element) => definitions[element];
       Function compileConstant = handler.compileConstant;
       FunctionElement target = constructor.definingConstructor.implementation;
-      Elements.addForwardingElementArgumentsToList<AstConstant>(constructor,

[Siggi Cherem (dart-lang), 2017/01/20 18:12:32]

oh my, this actually seems to be a bit broken. I think the last argument here
should not be compileConstant, but a function that wraps it into an AstConstant.

Johnni - do you agree?

[Johnni Winther, 2017/01/23 09:31:55]

It should. Weird why this hasn't failed at runtime...

[ahe, 2017/01/23 09:45:22]

What should I do?

[Johnni Winther, 2017/01/23 10:13:43]

Just remove the type argument to avoid the hint. I'll look into it.

+      Elements.addForwardingElementArgumentsToList(constructor,
           compiledArguments, target, compileArgument, compileConstant);
       CallStructure callStructure = new CallStructure(
           target.functionSignature.parameterCount, target.type.namedParameters);