Fix hints reported by analyzer.

pkg/compiler/lib/src/compile_time_constants.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library dart2js.compile_time_constant_evaluator;
 
 import 'common/resolution.dart' show Resolution;
 import 'common/tasks.dart' show CompilerTask, Measurer;
 import 'common.dart';
 import 'compiler.dart' show Compiler;
@@ skipping 1276 matching lines @@
    * the [fieldValues] map.
    */
   void evaluateConstructorInitializers() {
     ResolvedAst resolvedAst = constructor.resolvedAst;
     if (resolvedAst.kind != ResolvedAstKind.PARSED) {
       List<AstConstant> compiledArguments = <AstConstant>[];
 
       Function compileArgument = (element) => definitions[element];
       Function compileConstant = handler.compileConstant;
       FunctionElement target = constructor.definingConstructor.implementation;
-      Elements.addForwardingElementArgumentsToList<AstConstant>(constructor,

[Siggi Cherem (dart-lang), 2017/01/20 18:12:32]

oh my, this actually seems to be a bit broken. I think the last argument here
should not be compileConstant, but a function that wraps it into an AstConstant.

Johnni - do you agree?

[Johnni Winther, 2017/01/23 09:31:55]

It should. Weird why this hasn't failed at runtime...

[ahe, 2017/01/23 09:45:22]

What should I do?

[Johnni Winther, 2017/01/23 10:13:43]

Just remove the type argument to avoid the hint. I'll look into it.

+      Elements.addForwardingElementArgumentsToList(constructor,
           compiledArguments, target, compileArgument, compileConstant);
       CallStructure callStructure = new CallStructure(
           target.functionSignature.parameterCount, target.type.namedParameters);
       evaluateSuperOrRedirectSend(compiledArguments, callStructure, target);
       return;
     }
     FunctionExpression functionNode = resolvedAst.node;
     NodeList initializerList = functionNode.initializers;
 
     bool foundSuperOrRedirect = false;
@@ skipping 140 matching lines @@
 class _CompilerEnvironment implements Environment {
   final Compiler compiler;
 
   _CompilerEnvironment(this.compiler);
 
   @override
   String readFromEnvironment(String name) {
     return compiler.fromEnvironment(name);
   }
 }