Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Unified Diff: third_party/WebKit/Source/core/editing/VisibleSelection.h

Issue 2646963002: Stop dismissing selection handles when selection is kept (Closed)
Patch Set: avoid control flow in IMC and rebase Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/VisibleSelection.h
diff --git a/third_party/WebKit/Source/core/editing/VisibleSelection.h b/third_party/WebKit/Source/core/editing/VisibleSelection.h
index b8b221ca18d062cd1755df936713f3760fff55fa..103b0d56c1f2a3c28c3ad29c092fe1a075814841 100644
--- a/third_party/WebKit/Source/core/editing/VisibleSelection.h
+++ b/third_party/WebKit/Source/core/editing/VisibleSelection.h
@@ -122,6 +122,8 @@ class CORE_TEMPLATE_CLASS_EXPORT VisibleSelectionTemplate {
void appendTrailingWhitespace();
+ bool isHandleVisible() const { return m_isHandleVisible; }
+
// TODO(yosin) Most callers probably don't want these functions, but
// are using them for historical reasons. |toNormalizedEphemeralRange()|
// contracts the range around text, and moves the caret most backward
@@ -193,6 +195,8 @@ class CORE_TEMPLATE_CLASS_EXPORT VisibleSelectionTemplate {
// TODO(yosin): Once we unify start/end and base/extent, we should get rid
// of |m_hasTrailingWhitespace|.
bool m_hasTrailingWhitespace : 1;
+
+ bool m_isHandleVisible : 1; // True if handle should be visible.
yosin_UTC9 2017/01/25 03:49:08 Please don't add |m_isHandleVisible| to |VisibleSe
Changwan Ryu 2017/02/08 00:40:33 Done.
};
extern template class CORE_EXTERN_TEMPLATE_EXPORT

Powered by Google App Engine
This is Rietveld 408576698