Stop dismissing selection handles when selection is kept

third_party/WebKit/Source/core/editing/VisibleSelection.cpp

Index: third_party/WebKit/Source/core/editing/VisibleSelection.cpp
diff --git a/third_party/WebKit/Source/core/editing/VisibleSelection.cpp b/third_party/WebKit/Source/core/editing/VisibleSelection.cpp
index c2dac8421a0b8aeb429250c91966d3afb40fa4b8..e1b837ecadf5e2dbf9c857e2ec433e9576af8d0c 100644
--- a/third_party/WebKit/Source/core/editing/VisibleSelection.cpp
+++ b/third_party/WebKit/Source/core/editing/VisibleSelection.cpp
@@ -47,7 +47,8 @@ VisibleSelectionTemplate<Strategy>::VisibleSelectionTemplate()
       m_baseIsFirst(true),
       m_isDirectional(false),
       m_granularity(CharacterGranularity),
-      m_hasTrailingWhitespace(false) {}
+      m_hasTrailingWhitespace(false),
+      m_isHandleVisible(false) {}

[yosin_UTC9, 2017/01/25 03:49:08]

Please don't add |m_isHandleVisible| to |VisibleSelection|.
We hold |m_isHandleVisibile| in |FrameSelection|.

[Changwan Ryu, 2017/02/08 00:40:33]

Done.

 
 template <typename Strategy>
 VisibleSelectionTemplate<Strategy>::VisibleSelectionTemplate(
@@ -58,7 +59,8 @@ VisibleSelectionTemplate<Strategy>::VisibleSelectionTemplate(
       m_selectionType(NoSelection),
       m_isDirectional(selection.isDirectional()),
       m_granularity(selection.granularity()),
-      m_hasTrailingWhitespace(selection.hasTrailingWhitespace()) {
+      m_hasTrailingWhitespace(selection.hasTrailingWhitespace()),
+      m_isHandleVisible(selection.isHandleVisible()) {
   validate(m_granularity);
 }
 
@@ -109,7 +111,8 @@ VisibleSelectionTemplate<Strategy>::VisibleSelectionTemplate(
       m_baseIsFirst(other.m_baseIsFirst),
       m_isDirectional(other.m_isDirectional),
       m_granularity(other.m_granularity),
-      m_hasTrailingWhitespace(other.m_hasTrailingWhitespace) {}
+      m_hasTrailingWhitespace(other.m_hasTrailingWhitespace),
+      m_isHandleVisible(other.m_isHandleVisible) {}
 
 template <typename Strategy>
 VisibleSelectionTemplate<Strategy>& VisibleSelectionTemplate<Strategy>::
@@ -124,6 +127,7 @@ operator=(const VisibleSelectionTemplate<Strategy>& other) {
   m_isDirectional = other.m_isDirectional;
   m_granularity = other.m_granularity;
   m_hasTrailingWhitespace = other.m_hasTrailingWhitespace;
+  m_isHandleVisible = other.m_isHandleVisible;
   return *this;
 }
 
@@ -137,6 +141,7 @@ SelectionTemplate<Strategy> VisibleSelectionTemplate<Strategy>::asSelection()
       .setGranularity(m_granularity)
       .setIsDirectional(m_isDirectional)
       .setHasTrailingWhitespace(m_hasTrailingWhitespace)
+      .setIsHandleVisible(m_isHandleVisible)
       .build();
 }