Stop dismissing selection handles when selection is kept

third_party/WebKit/Source/core/editing/VisibleSelection.cpp

 /*
  * Copyright (C) 2004, 2005, 2006 Apple Computer, Inc.  All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 29 matching lines @@
 
 namespace blink {
 
 template <typename Strategy>
 VisibleSelectionTemplate<Strategy>::VisibleSelectionTemplate()
     : m_affinity(TextAffinity::Downstream),
       m_selectionType(NoSelection),
       m_baseIsFirst(true),
       m_isDirectional(false),
       m_granularity(CharacterGranularity),
-      m_hasTrailingWhitespace(false) {}
+      m_hasTrailingWhitespace(false),
+      m_isHandleVisible(false) {}

[yosin_UTC9, 2017/01/25 03:49:08]

Please don't add |m_isHandleVisible| to |VisibleSelection|.
We hold |m_isHandleVisibile| in |FrameSelection|.

[Changwan Ryu, 2017/02/08 00:40:33]

Done.

 
 template <typename Strategy>
 VisibleSelectionTemplate<Strategy>::VisibleSelectionTemplate(
     const SelectionTemplate<Strategy>& selection)
     : m_base(selection.base()),
       m_extent(selection.extent()),
       m_affinity(selection.affinity()),
       m_selectionType(NoSelection),
       m_isDirectional(selection.isDirectional()),
       m_granularity(selection.granularity()),
-      m_hasTrailingWhitespace(selection.hasTrailingWhitespace()) {
+      m_hasTrailingWhitespace(selection.hasTrailingWhitespace()),
+      m_isHandleVisible(selection.isHandleVisible()) {
   validate(m_granularity);
 }
 
 template <typename Strategy>
 VisibleSelectionTemplate<Strategy> VisibleSelectionTemplate<Strategy>::create(
     const SelectionTemplate<Strategy>& selection) {
   return VisibleSelectionTemplate(selection);
 }
 
 VisibleSelection createVisibleSelection(const SelectionInDOMTree& selection) {
@@ skipping 30 matching lines @@
     const VisibleSelectionTemplate<Strategy>& other)
     : m_base(other.m_base),
       m_extent(other.m_extent),
       m_start(other.m_start),
       m_end(other.m_end),
       m_affinity(other.m_affinity),
       m_selectionType(other.m_selectionType),
       m_baseIsFirst(other.m_baseIsFirst),
       m_isDirectional(other.m_isDirectional),
       m_granularity(other.m_granularity),
-      m_hasTrailingWhitespace(other.m_hasTrailingWhitespace) {}
+      m_hasTrailingWhitespace(other.m_hasTrailingWhitespace),
+      m_isHandleVisible(other.m_isHandleVisible) {}
 
 template <typename Strategy>
 VisibleSelectionTemplate<Strategy>& VisibleSelectionTemplate<Strategy>::
 operator=(const VisibleSelectionTemplate<Strategy>& other) {
   m_base = other.m_base;
   m_extent = other.m_extent;
   m_start = other.m_start;
   m_end = other.m_end;
   m_affinity = other.m_affinity;
   m_selectionType = other.m_selectionType;
   m_baseIsFirst = other.m_baseIsFirst;
   m_isDirectional = other.m_isDirectional;
   m_granularity = other.m_granularity;
   m_hasTrailingWhitespace = other.m_hasTrailingWhitespace;
+  m_isHandleVisible = other.m_isHandleVisible;
   return *this;
 }
 
 template <typename Strategy>
 SelectionTemplate<Strategy> VisibleSelectionTemplate<Strategy>::asSelection()
     const {
   typename SelectionTemplate<Strategy>::Builder builder;
   if (m_base.isNotNull())
     builder.setBaseAndExtent(m_base, m_extent);
   return builder.setAffinity(m_affinity)
       .setGranularity(m_granularity)
       .setIsDirectional(m_isDirectional)
       .setHasTrailingWhitespace(m_hasTrailingWhitespace)
+      .setIsHandleVisible(m_isHandleVisible)
       .build();
 }
 
 template <typename Strategy>
 void VisibleSelectionTemplate<Strategy>::setBase(
     const PositionTemplate<Strategy>& position) {
   DCHECK(!needsLayoutTreeUpdate(position));
   m_base = position;
   validate();
 }
@@ skipping 693 matching lines @@
 
 void showTree(const blink::VisibleSelectionInFlatTree& sel) {
   sel.showTreeForThis();
 }
 
 void showTree(const blink::VisibleSelectionInFlatTree* sel) {
   if (sel)
     sel->showTreeForThis();
 }
 #endif