Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 2646903002: Add a UseCounter for selection intersection in Selection.addRange(). (Closed)

Created:
3 years, 11 months ago by tkent
Modified:
3 years, 11 months ago
Reviewers:
haraken, yosin_UTC9
CC:
asvitkine+watch_chromium.org, blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a UseCounter for selection intersection in Selection.addRange(). This CL has no user-visible behavior changes. BUG=682927 Review-Url: https://codereview.chromium.org/2646903002 Cr-Commit-Position: refs/heads/master@{#444980} Committed: https://chromium.googlesource.com/chromium/src/+/bc3500b781a02784c3624110e9ea70e022f2cd64

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M third_party/WebKit/Source/core/editing/DOMSelection.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 chunk +1 line, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
tkent
yosin@, would you review Blink changes please? haraken@, would you approve histograms.xml please?
3 years, 11 months ago (2017-01-20 01:37:08 UTC) #4
haraken
LGTM
3 years, 11 months ago (2017-01-20 02:16:56 UTC) #5
yosin_UTC9
lgtm Thanks!
3 years, 11 months ago (2017-01-20 02:22:14 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2646903002/1
3 years, 11 months ago (2017-01-20 03:10:40 UTC) #10
commit-bot: I haz the power
3 years, 11 months ago (2017-01-20 04:18:14 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/bc3500b781a02784c3624110e9ea...

Powered by Google App Engine
This is Rietveld 408576698