Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 2646893002: Move WebAssociatedURLLoaderImpl's error timer to the frame's loading task runner. (Closed)

Created:
3 years, 11 months ago by jbroman
Modified:
3 years, 11 months ago
Reviewers:
haraken
CC:
blink-reviews, chromium-reviews, kinuko+watch, tyoshino (SeeGerritForStatus)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move WebAssociatedURLLoaderImpl's error timer to the frame's loading task runner. If some user turns out to need these callbacks even when the frame is suspended or destroyed, it should be moved instead to the general-purpose loading task runner. BUG=624694 Review-Url: https://codereview.chromium.org/2646893002 Cr-Commit-Position: refs/heads/master@{#444963} Committed: https://chromium.googlesource.com/chromium/src/+/2ca43b1c99640f0578ba96397f820e1a0cfe7485

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -8 lines) Patch
M third_party/WebKit/Source/web/WebAssociatedURLLoaderImpl.cpp View 6 chunks +18 lines, -8 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
jbroman
I _think_ this ought to be fine, but some of the uses are sufficiently indirect ...
3 years, 11 months ago (2017-01-20 01:54:15 UTC) #4
haraken
First, this should be an Unspeced task. Second, UnspecedLoading makes more sense than UnspecedTimer for ...
3 years, 11 months ago (2017-01-20 02:19:04 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2646893002/1
3 years, 11 months ago (2017-01-20 02:22:51 UTC) #8
commit-bot: I haz the power
3 years, 11 months ago (2017-01-20 03:13:07 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2ca43b1c99640f0578ba96397f82...

Powered by Google App Engine
This is Rietveld 408576698