Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1317)

Issue 2646873004: Enable emplace_back for zone containers (Closed)

Created:
3 years, 11 months ago by Clemens Hammacher
Modified:
3 years, 11 months ago
Reviewers:
Igor Sheludko, titzer
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Enable emplace_back for zone containers As required by C++11, this CL changes the zone allocator to be able to construct and destroy arbitrary types, and accept arbitrary arguments for construct, passing them via perfect forwarding. I also change some push_back to emplace_back. Some of those did not compile before. R=ishell@chromium.org, titzer@chromium.org Review-Url: https://codereview.chromium.org/2646873004 Cr-Commit-Position: refs/heads/master@{#42597} Committed: https://chromium.googlesource.com/v8/v8/+/14f470cafd909c7c5805edc0257048f495491f66

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -8 lines) Patch
M src/wasm/module-decoder.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/wasm/wasm-interpreter.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/wasm/wasm-text.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/zone/zone-allocator.h View 1 chunk +8 lines, -3 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
Clemens Hammacher
3 years, 11 months ago (2017-01-20 13:58:10 UTC) #7
titzer
On 2017/01/20 13:58:10, Clemens Hammacher wrote: lgtm. Seems like this will simplify a lot of ...
3 years, 11 months ago (2017-01-20 14:02:52 UTC) #8
Clemens Hammacher
On 2017/01/20 at 14:02:52, titzer wrote: > On 2017/01/20 13:58:10, Clemens Hammacher wrote: > > ...
3 years, 11 months ago (2017-01-20 14:05:22 UTC) #9
Igor Sheludko
lgtm
3 years, 11 months ago (2017-01-23 10:35:55 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2646873004/1
3 years, 11 months ago (2017-01-23 10:37:13 UTC) #12
commit-bot: I haz the power
3 years, 11 months ago (2017-01-23 11:12:33 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/14f470cafd909c7c5805edc0257048f4954...

Powered by Google App Engine
This is Rietveld 408576698